Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1644823002: Remove library tags, they aren't needed (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 10 months ago
Reviewers:
vsm, Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove library tags, they aren't needed (with one exception: libs that have parts) R=rnystrom@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/56cbbf67d400d03ac6aab6aa8359229f7a33fdd3

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -61 lines) Patch
M lib/devc.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/runtime/messages_widget.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/analysis_context.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/closure/closure_annotation.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/closure/closure_annotator.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/closure/closure_type.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/ast_builder.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/code_generator.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/html_codegen.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/js_field_storage.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/js_interop.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/js_metalet.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/js_names.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/js_printer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/module_builder.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/reify_coercions.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/codegen/side_effect_analysis.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/compiler.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/dart_sdk.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/info.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/js/characters.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/js/precedence.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/multi_package_resolver.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/options.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/report.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/report/html_gen.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/report/html_reporter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/runner/file_utils.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/runner/runtime_utils.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/runner/v8_runner.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/server/dependency_graph.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/server/server.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/summary.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/utils.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 chunk +2 lines, -2 lines 1 comment Download
M test/codegen/expect/collection/wrappers.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Jennifer Messerly
https://codereview.chromium.org/1644823002/diff/20001/test/codegen/expect/collection/src/unmodifiable_wrappers.txt File test/codegen/expect/collection/src/unmodifiable_wrappers.txt (right): https://codereview.chromium.org/1644823002/diff/20001/test/codegen/expect/collection/src/unmodifiable_wrappers.txt#newcode2 test/codegen/expect/collection/src/unmodifiable_wrappers.txt:2: severe: [AnalyzerMessage] Missing concrete implementation of 'Iterable.expand' and 'Iterable.map' ...
4 years, 11 months ago (2016-01-28 01:02:02 UTC) #4
Bob Nystrom
LGTM!!!
4 years, 10 months ago (2016-01-28 17:07:06 UTC) #5
Jennifer Messerly
4 years, 10 months ago (2016-01-29 17:25:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
56cbbf67d400d03ac6aab6aa8359229f7a33fdd3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698