Don't crash when navigating an OOPIF to a URL that fails.

Don't crash when navigating an OOPIF to a URL that fails.

New test from lfg@chromium.org.

BUG=558016
TEST=From the main frame, navigate an OOPIF to a non-existent URL.

Committed: https://crrev.com/9321868ae46ce565e86db860d000785795efb533
Cr-Commit-Position: refs/heads/master@{#372013}

[Charlie Reis, 2016-01-28 00:48:49]

Description was changed from

==========
Don't crash when navigating an OOPIF to a URL that fails.

BUG=558016
TEST=From the main frame, navigate an OOPIF to a non-existent URL.
==========

to

==========
Don't crash when navigating an OOPIF to a URL that fails.

New test from lfg@chromium.org.

BUG=558016
TEST=From the main frame, navigate an OOPIF to a non-existent URL.
==========

[Charlie Reis, 2016-01-28 00:48:49]

creis@chromium.org changed reviewers:
+ japhet@chromium.org

[Charlie Reis, 2016-01-28 00:51:37]

Nate, can you take a look?  This is a top crasher during our trial, and it's
easy to reproduce on http://csreis.github.io/tests/cross-site-iframe.html. 
(Just click Go Cross Site and then call navFrame with a bad URL in the DevTools
console.)

It's not clear to me how much is still broken after this, but this will at least
prevent the crash.

https://codereview.chromium.org/1644813002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/1644813002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1212: // FIXME: For now,
fallback content doesn't work cross process.
Is this FIXME still needed?  The network error page does show up in the subframe
after this fix, so I'm not sure whether the fallback content is broken or not.

[Nate Chapin, 2016-01-28 00:56:08]

lgtm

https://codereview.chromium.org/1644813002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/1644813002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1212: // FIXME: For now,
fallback content doesn't work cross process.
On 2016/01/28 00:51:37, Charlie Reis wrote:
> Is this FIXME still needed?  The network error page does show up in the
subframe
> after this fix, so I'm not sure whether the fallback content is broken or not.

Fallback content in this sense is, e.g., an image that gets displayed when a
plugin fails to load. I don't think that's what you're talking about?

[Charlie Reis, 2016-01-28 01:02:17]

Thanks!

https://codereview.chromium.org/1644813002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/1644813002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1212: // FIXME: For now,
fallback content doesn't work cross process.
On 2016/01/28 00:56:08, Nate Chapin wrote:
> On 2016/01/28 00:51:37, Charlie Reis wrote:
> > Is this FIXME still needed?  The network error page does show up in the
> subframe
> > after this fix, so I'm not sure whether the fallback content is broken or
not.
> 
> Fallback content in this sense is, e.g., an image that gets displayed when a
> plugin fails to load. I don't think that's what you're talking about?

Ok, that sounds like something else.  I'll leave the FIXME in case it matters
for another case.

[Charlie Reis, 2016-01-28 01:02:31]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-01-28 01:04:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644813002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644813002/1

[commit-bot: I haz the power, 2016-01-28 02:51:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 02:51:51]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie Reis, 2016-01-28 03:36:28]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-01-28 03:36:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644813002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644813002/1

[commit-bot: I haz the power, 2016-01-28 04:34:16]

Description was changed from

==========
Don't crash when navigating an OOPIF to a URL that fails.

New test from lfg@chromium.org.

BUG=558016
TEST=From the main frame, navigate an OOPIF to a non-existent URL.
==========

to

==========
Don't crash when navigating an OOPIF to a URL that fails.

New test from lfg@chromium.org.

BUG=558016
TEST=From the main frame, navigate an OOPIF to a non-existent URL.
==========

[commit-bot: I haz the power, 2016-01-28 04:34:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-28 04:35:06]

Description was changed from

==========
Don't crash when navigating an OOPIF to a URL that fails.

New test from lfg@chromium.org.

BUG=558016
TEST=From the main frame, navigate an OOPIF to a non-existent URL.
==========

to

==========
Don't crash when navigating an OOPIF to a URL that fails.

New test from lfg@chromium.org.

BUG=558016
TEST=From the main frame, navigate an OOPIF to a non-existent URL.

Committed: https://crrev.com/9321868ae46ce565e86db860d000785795efb533
Cr-Commit-Position: refs/heads/master@{#372013}
==========

[commit-bot: I haz the power, 2016-01-28 04:35:12]

Patchset 1 (id:??) landed as
https://crrev.com/9321868ae46ce565e86db860d000785795efb533
Cr-Commit-Position: refs/heads/master@{#372013}