Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1644803002: rewrite_to_chrome_style: Don't put a trailing _ on static consts. (Closed)

Created:
4 years, 11 months ago by danakj
Modified:
4 years, 11 months ago
Reviewers:
dcheng
CC:
chromium-reviews, hans, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rewrite_to_chrome_style: Don't put a trailing _ on static consts. These are named in kFooBar style, which doesn't need an underscore. The name should not change if we moved it to an enum, and this is the overwhelming (always used) style for nested constants in chromium. R=dcheng BUG=580746 Committed: https://crrev.com/0915b0fadc62314b8eeb497bf37605158d31b5e9 Cr-Commit-Position: refs/heads/master@{#371951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danakj
4 years, 11 months ago (2016-01-28 00:28:50 UTC) #1
dcheng
lgtm
4 years, 11 months ago (2016-01-28 00:32:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644803002/1
4 years, 11 months ago (2016-01-28 00:34:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644803002/1
4 years, 11 months ago (2016-01-28 00:44:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 01:16:06 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 01:17:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0915b0fadc62314b8eeb497bf37605158d31b5e9
Cr-Commit-Position: refs/heads/master@{#371951}

Powered by Google App Engine
This is Rietveld 408576698