Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: runtime/vm/code_descriptors.cc

Issue 1644793002: Replace intptr_t with TokenDescriptor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_descriptors.cc
diff --git a/runtime/vm/code_descriptors.cc b/runtime/vm/code_descriptors.cc
index ac4cb24a38cd22f31507f39f3d3f876deed2ce01..8d1fcbcc9c4ae4a7ef218d5758ce811ec61d325c 100644
--- a/runtime/vm/code_descriptors.cc
+++ b/runtime/vm/code_descriptors.cc
@@ -10,7 +10,7 @@ namespace dart {
void DescriptorList::AddDescriptor(RawPcDescriptors::Kind kind,
intptr_t pc_offset,
intptr_t deopt_id,
- intptr_t token_pos,
+ TokenDescriptor token_pos,
intptr_t try_index) {
ASSERT((kind == RawPcDescriptors::kRuntimeCall) ||
(kind == RawPcDescriptors::kOther) ||
@@ -24,11 +24,12 @@ void DescriptorList::AddDescriptor(RawPcDescriptors::Kind kind,
PcDescriptors::EncodeInteger(&encoded_data_, merged_kind_try);
PcDescriptors::EncodeInteger(&encoded_data_, pc_offset - prev_pc_offset);
PcDescriptors::EncodeInteger(&encoded_data_, deopt_id - prev_deopt_id);
- PcDescriptors::EncodeInteger(&encoded_data_, token_pos - prev_token_pos);
+ PcDescriptors::EncodeInteger(&encoded_data_,
+ token_pos.value() - prev_token_pos);
prev_pc_offset = pc_offset;
prev_deopt_id = deopt_id;
- prev_token_pos = token_pos;
+ prev_token_pos = token_pos.value();
}
}
@@ -43,12 +44,13 @@ RawPcDescriptors* DescriptorList::FinalizePcDescriptors(uword entry_point) {
void CodeSourceMapBuilder::AddEntry(intptr_t pc_offset,
- intptr_t token_pos) {
+ TokenDescriptor token_pos) {
CodeSourceMap::EncodeInteger(&encoded_data_, pc_offset - prev_pc_offset);
- CodeSourceMap::EncodeInteger(&encoded_data_, token_pos - prev_token_pos);
+ CodeSourceMap::EncodeInteger(&encoded_data_,
+ token_pos.value() - prev_token_pos);
prev_pc_offset = pc_offset;
- prev_token_pos = token_pos;
+ prev_token_pos = token_pos.value();
}

Powered by Google App Engine
This is Rietveld 408576698