Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: runtime/vm/ast.cc

Issue 1644793002: Replace intptr_t with TokenDescriptor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/ast.cc
diff --git a/runtime/vm/ast.cc b/runtime/vm/ast.cc
index 2deefa29ca5166210d6db5ba98e2943765b116f7..69e1e5bfd2c7b6e54934c152171cc0416b413eae 100644
--- a/runtime/vm/ast.cc
+++ b/runtime/vm/ast.cc
@@ -91,7 +91,7 @@ void ArgumentListNode::VisitChildren(AstNodeVisitor* visitor) const {
}
-LetNode::LetNode(intptr_t token_pos)
+LetNode::LetNode(TokenDescriptor token_pos)
: AstNode(token_pos),
vars_(1),
initializers_(1),
@@ -102,7 +102,7 @@ LocalVariable* LetNode::AddInitializer(AstNode* node) {
initializers_.Add(node);
char name[64];
OS::SNPrint(name, sizeof(name), ":lt%" Pd "_%" Pd "",
- token_pos(), vars_.length());
+ token_pos().value(), vars_.length());
Ivan Posva 2016/02/01 17:16:52 value() or ToCString()?
Cutch 2016/02/02 18:00:20 ToCString(). Done here and elsewhere.
LocalVariable* temp_var =
new LocalVariable(token_pos(),
String::ZoneHandle(Symbols::New(name)),
@@ -433,7 +433,7 @@ const Instance* BinaryOpNode::EvalConstExpr() const {
}
-AstNode* UnaryOpNode::UnaryOpOrLiteral(intptr_t token_pos,
+AstNode* UnaryOpNode::UnaryOpOrLiteral(TokenDescriptor token_pos,
Token::Kind kind,
AstNode* operand) {
AstNode* new_operand = operand->ApplyUnaryOp(kind);

Powered by Google App Engine
This is Rietveld 408576698