Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: runtime/vm/source_report.h

Issue 1644793002: Replace intptr_t with TokenDescriptor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/snapshot_test.cc ('k') | runtime/vm/source_report.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/source_report.h
diff --git a/runtime/vm/source_report.h b/runtime/vm/source_report.h
index 9b03a232ffdea718482f756436d67bf76852cf89..77bf6c269ba079e334afec380943f4777d8ebd5a 100644
--- a/runtime/vm/source_report.h
+++ b/runtime/vm/source_report.h
@@ -9,6 +9,7 @@
#include "vm/flags.h"
#include "vm/hash_map.h"
#include "vm/object.h"
+#include "vm/token_position.h"
namespace dart {
@@ -38,11 +39,12 @@ class SourceReport {
// If script is null, then the report is generated for all scripts
// in the isolate.
void PrintJSON(JSONStream* js, const Script& script,
- intptr_t start_pos = -1, intptr_t end_pos = -1);
+ TokenPosition start_pos = TokenPosition::kNoSource,
+ TokenPosition end_pos = TokenPosition::kNoSource);
private:
void Init(Thread* thread, const Script* script,
- intptr_t start_pos, intptr_t end_pos);
+ TokenPosition start_pos, TokenPosition end_pos);
Thread* thread() const { return thread_; }
Zone* zone() const { return thread_->zone(); }
@@ -100,8 +102,8 @@ class SourceReport {
CompileMode compile_mode_;
Thread* thread_;
const Script* script_;
- intptr_t start_pos_;
- intptr_t end_pos_;
+ TokenPosition start_pos_;
+ TokenPosition end_pos_;
GrowableArray<ScriptTableEntry> script_table_entries_;
DirectChainedHashMap<ScriptTableTrait> script_table_;
intptr_t next_script_index_;
« no previous file with comments | « runtime/vm/snapshot_test.cc ('k') | runtime/vm/source_report.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698