Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: runtime/vm/flow_graph_builder.h

Issue 1644793002: Replace intptr_t with TokenDescriptor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.h
diff --git a/runtime/vm/flow_graph_builder.h b/runtime/vm/flow_graph_builder.h
index 2c2d14d713b3d1746b7fd32f7852ddfe686c98e7..6dc14cefc1983cf06842428ecff9c451fbe2d8f2 100644
--- a/runtime/vm/flow_graph_builder.h
+++ b/runtime/vm/flow_graph_builder.h
@@ -288,7 +288,7 @@ class EffectGraphVisitor : public AstNodeVisitor {
// Append a 'while loop' test and back edge to this graph, depending on
// which parts are reachable. Afterward, the graph exit is the false
// successor of the loop condition.
- void TieLoop(intptr_t token_pos,
+ void TieLoop(TokenPosition token_pos,
const TestGraphVisitor& test_fragment,
const EffectGraphVisitor& body_fragment,
const EffectGraphVisitor& test_preamble_fragment);
@@ -300,21 +300,22 @@ class EffectGraphVisitor : public AstNodeVisitor {
// This implementation shares state among visitors by using the builder.
// The implementation is incorrect if a visitor that hits a return is not
// actually added to the graph.
- void AddReturnExit(intptr_t token_pos, Value* value);
+ void AddReturnExit(TokenPosition token_pos, Value* value);
protected:
Definition* BuildStoreTemp(const LocalVariable& local,
Value* value,
- intptr_t token_pos);
- Definition* BuildStoreExprTemp(Value* value, intptr_t token_pos);
- Definition* BuildLoadExprTemp(intptr_t token_pos);
+ TokenPosition token_pos);
+ Definition* BuildStoreExprTemp(Value* value, TokenPosition token_pos);
+ Definition* BuildLoadExprTemp(TokenPosition token_pos);
Definition* BuildStoreLocal(const LocalVariable& local,
Value* value,
- intptr_t token_pos);
+ TokenPosition token_pos);
Definition* BuildLoadLocal(const LocalVariable& local,
- intptr_t token_pos);
- LoadLocalInstr* BuildLoadThisVar(LocalScope* scope, intptr_t token_pos);
+ TokenPosition token_pos);
+ LoadLocalInstr* BuildLoadThisVar(LocalScope* scope,
+ TokenPosition token_pos);
LoadFieldInstr* BuildNativeGetter(
NativeBodyNode* node,
MethodRecognizer::Kind kind,
@@ -335,27 +336,27 @@ class EffectGraphVisitor : public AstNodeVisitor {
// allocation call.
// May be called only if allocating an object of a parameterized class.
Value* BuildInstantiatedTypeArguments(
- intptr_t token_pos,
+ TokenPosition token_pos,
const TypeArguments& type_arguments);
void BuildTypecheckPushArguments(
- intptr_t token_pos,
+ TokenPosition token_pos,
PushArgumentInstr** push_instantiator_type_arguments);
- void BuildTypecheckArguments(intptr_t token_pos,
+ void BuildTypecheckArguments(TokenPosition token_pos,
Value** instantiator_type_arguments);
- Value* BuildInstantiator(intptr_t token_pos);
- Value* BuildInstantiatorTypeArguments(intptr_t token_pos,
+ Value* BuildInstantiator(TokenPosition token_pos);
+ Value* BuildInstantiatorTypeArguments(TokenPosition token_pos,
const Class& instantiator_class,
Value* instantiator);
// Perform a type check on the given value.
- AssertAssignableInstr* BuildAssertAssignable(intptr_t token_pos,
+ AssertAssignableInstr* BuildAssertAssignable(TokenPosition token_pos,
Value* value,
const AbstractType& dst_type,
const String& dst_name);
// Perform a type check on the given value and return it.
- Value* BuildAssignableValue(intptr_t token_pos,
+ Value* BuildAssignableValue(TokenPosition token_pos,
Value* value,
const AbstractType& dst_type,
const String& dst_name);
@@ -374,7 +375,7 @@ class EffectGraphVisitor : public AstNodeVisitor {
StrictCompareInstr* BuildStrictCompare(AstNode* left,
AstNode* right,
Token::Kind kind,
- intptr_t token_pos);
+ TokenPosition token_pos);
virtual void BuildTypeTest(ComparisonNode* node);
virtual void BuildTypeCast(ComparisonNode* node);
@@ -399,12 +400,12 @@ class EffectGraphVisitor : public AstNodeVisitor {
PushArgumentInstr* alloc_value);
void BuildSaveContext(const LocalVariable& variable,
- intptr_t token_pos);
+ TokenPosition token_pos);
void BuildRestoreContext(const LocalVariable& variable,
- intptr_t token_pos);
+ TokenPosition token_pos);
- Definition* BuildStoreContext(Value* value, intptr_t token_pos);
- Definition* BuildCurrentContext(intptr_t token_pos);
+ Definition* BuildStoreContext(Value* value, TokenPosition token_pos);
+ Definition* BuildCurrentContext(TokenPosition token_pos);
void BuildThrowNode(ThrowNode* node);
@@ -417,7 +418,7 @@ class EffectGraphVisitor : public AstNodeVisitor {
bool is_super_invocation);
StaticCallInstr* BuildThrowNoSuchMethodError(
- intptr_t token_pos,
+ TokenPosition token_pos,
const Class& function_class,
const String& function_name,
ArgumentListNode* function_arguments,
@@ -426,22 +427,22 @@ class EffectGraphVisitor : public AstNodeVisitor {
void BuildStaticSetter(StaticSetterNode* node, bool result_is_needed);
Definition* BuildStoreStaticField(StoreStaticFieldNode* node,
bool result_is_needed,
- intptr_t token_pos);
+ TokenPosition token_pos);
void BuildClosureCall(ClosureCallNode* node, bool result_needed);
- Value* BuildNullValue(intptr_t token_pos);
+ Value* BuildNullValue(TokenPosition token_pos);
// Returns true if the run-time type check can be eliminated.
- bool CanSkipTypeCheck(intptr_t token_pos,
+ bool CanSkipTypeCheck(TokenPosition token_pos,
Value* value,
const AbstractType& dst_type,
const String& dst_name);
// Helpers for allocating and deallocating temporary locals on top of the
// expression stack.
- LocalVariable* EnterTempLocalScope(Value* value, intptr_t token_pos);
- Definition* ExitTempLocalScope(LocalVariable* var, intptr_t token_pos);
+ LocalVariable* EnterTempLocalScope(Value* value, TokenPosition token_pos);
+ Definition* ExitTempLocalScope(LocalVariable* var, TokenPosition token_pos);
void BuildLetTempExpressions(LetNode* node);
@@ -545,7 +546,7 @@ class ValueGraphVisitor : public EffectGraphVisitor {
class TestGraphVisitor : public ValueGraphVisitor {
public:
TestGraphVisitor(FlowGraphBuilder* owner,
- intptr_t condition_token_pos)
+ TokenPosition condition_token_pos)
: ValueGraphVisitor(owner),
true_successor_addresses_(1),
false_successor_addresses_(1),
@@ -559,7 +560,7 @@ class TestGraphVisitor : public ValueGraphVisitor {
virtual void VisitBinaryOpNode(BinaryOpNode* node);
- intptr_t condition_token_pos() const { return condition_token_pos_; }
+ TokenPosition condition_token_pos() const { return condition_token_pos_; }
private:
// Construct and concatenate a Branch instruction to this graph fragment.
@@ -584,7 +585,7 @@ class TestGraphVisitor : public ValueGraphVisitor {
GrowableArray<TargetEntryInstr**> true_successor_addresses_;
GrowableArray<TargetEntryInstr**> false_successor_addresses_;
- intptr_t condition_token_pos_;
+ TokenPosition condition_token_pos_;
};
} // namespace dart
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698