Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1644773004: Renames some WindowManager classes (Closed)

Created:
4 years, 10 months ago by sky
Modified:
4 years, 10 months ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renames some WindowManager classes WindowManager->WindowManagerDeprecated (i'll nuke this entirely soon) WindowManagerInternal->WindowManager I'll move the WindowManager classes into window_manager.mojom once I nuke WindowManagerDeprecated (I can't now because of a cycle). BUG=none TEST=none R=ben@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/e18185a7b5251585e405e1672c5436d0ce10ab8c Cr-Commit-Position: refs/heads/master@{#372006}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -145 lines) Patch
M components/mus/mus_app.h View 3 chunks +11 lines, -9 lines 0 comments Download
M components/mus/mus_app.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 3 chunks +6 lines, -8 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_host_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/public/cpp/tests/test_window_tree.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/mus/public/cpp/window_tree_host_factory.h View 1 chunk +8 lines, -7 lines 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 1 chunk +1 line, -17 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 1 3 chunks +28 lines, -15 lines 0 comments Download
M components/mus/public/interfaces/window_tree_host.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/access_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/client_connection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/ws/client_connection.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/mus/ws/default_access_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/default_access_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/forwarding_window_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/ws/forwarding_window_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/window_manager_access_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_manager_access_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 3 chunks +5 lines, -3 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_impl.h View 3 chunks +7 lines, -7 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 8 chunks +11 lines, -13 lines 0 comments Download
M mash/wm/window_manager_application.h View 3 chunks +9 lines, -7 lines 0 comments Download
M mash/wm/window_manager_application.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M mash/wm/window_manager_apptest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mash/wm/window_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sky
4 years, 10 months ago (2016-01-28 03:39:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644773004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644773004/20001
4 years, 10 months ago (2016-01-28 03:41:08 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 04:14:30 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 04:15:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e18185a7b5251585e405e1672c5436d0ce10ab8c
Cr-Commit-Position: refs/heads/master@{#372006}

Powered by Google App Engine
This is Rietveld 408576698