Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/ui/uma_browsing_activity_observer.cc

Issue 1644773003: Remove BrowserIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-desktop-1
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/uma_browsing_activity_observer.cc
diff --git a/chrome/browser/ui/uma_browsing_activity_observer.cc b/chrome/browser/ui/uma_browsing_activity_observer.cc
index e5f79271ea9ce5fe5abdf294916dd5369379cd2d..4b56cfcbf2764378fb321bcca5c14257cc044795 100644
--- a/chrome/browser/ui/uma_browsing_activity_observer.cc
+++ b/chrome/browser/ui/uma_browsing_activity_observer.cc
@@ -9,7 +9,7 @@
#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
-#include "chrome/browser/ui/browser_iterator.h"
+#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "components/search_engines/template_url_service.h"
@@ -96,9 +96,8 @@ void UMABrowsingActivityObserver::LogBrowserTabCount() const {
int app_window_count = 0;
int popup_window_count = 0;
int tabbed_window_count = 0;
- for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+ for (auto* browser : *BrowserList::GetInstance()) {
// Record how many tabs each window has open.
- Browser* browser = *it;
UMA_HISTOGRAM_CUSTOM_COUNTS("Tabs.TabCountPerWindow",
browser->tab_strip_model()->count(),
1, 200, 50);

Powered by Google App Engine
This is Rietveld 408576698