Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 1644773003: Remove BrowserIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-desktop-1
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_browsertest.cc b/chrome/browser/ui/panels/panel_browsertest.cc
index b510f88b817ec6bd65acd031a247e9699b612d61..17891fa72d9a128711ae4206f95335ca4d0a48de 100644
--- a/chrome/browser/ui/panels/panel_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_browsertest.cc
@@ -19,7 +19,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
-#include "chrome/browser/ui/browser_iterator.h"
+#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/panels/base_panel_browser_test.h"
#include "chrome/browser/ui/panels/docked_panel_collection.h"
@@ -1637,10 +1637,10 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DevTools) {
EXPECT_EQ(num_browsers, chrome::GetBrowserCount(
browser()->profile(),
browser()->host_desktop_type()));
- for (chrome::BrowserIterator iter; !iter.done(); iter.Next()) {
- if (*iter == browser())
+ for (auto* b : *BrowserList::GetInstance()) {
+ if (b == browser())
continue;
- ASSERT_TRUE((*iter)->is_devtools());
+ ASSERT_TRUE(b->is_devtools());
}
panel->Close();
@@ -1671,10 +1671,10 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DevToolsConsole) {
EXPECT_EQ(num_browsers, chrome::GetBrowserCount(
browser()->profile(),
browser()->host_desktop_type()));
- for (chrome::BrowserIterator iter; !iter.done(); iter.Next()) {
- if (*iter == browser())
+ for (auto* b : *BrowserList::GetInstance()) {
+ if (b == browser())
continue;
- ASSERT_TRUE((*iter)->is_devtools());
+ ASSERT_TRUE(b->is_devtools());
}
panel->Close();
« no previous file with comments | « chrome/browser/ui/extensions/hosted_app_browsertest.cc ('k') | chrome/browser/ui/settings_window_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698