Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2470)

Unified Diff: chrome/browser/devtools/remote_debugging_server.cc

Issue 1644773003: Remove BrowserIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-desktop-1
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/download/download_status_updater_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/remote_debugging_server.cc
diff --git a/chrome/browser/devtools/remote_debugging_server.cc b/chrome/browser/devtools/remote_debugging_server.cc
index ba64ad2fbba89a05eadc8da44c6c70c654a17365..b916a307bbf30ab9ee92564ffcb38ac341ce9945 100644
--- a/chrome/browser/devtools/remote_debugging_server.cc
+++ b/chrome/browser/devtools/remote_debugging_server.cc
@@ -15,7 +15,7 @@
#include "chrome/browser/history/top_sites_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_iterator.h"
+#include "chrome/browser/ui/browser_list.h"
#include "chrome/common/chrome_content_client.h"
#include "chrome/common/chrome_paths.h"
#include "components/devtools_http_handler/devtools_http_handler.h"
@@ -104,8 +104,8 @@ ChromeDevToolsHttpHandlerDelegate::~ChromeDevToolsHttpHandlerDelegate() {
std::string ChromeDevToolsHttpHandlerDelegate::GetDiscoveryPageHTML() {
std::set<Profile*> profiles;
- for (chrome::BrowserIterator it; !it.done(); it.Next())
- profiles.insert((*it)->profile());
+ for (auto* browser : *BrowserList::GetInstance())
+ profiles.insert(browser->profile());
for (std::set<Profile*>::iterator it = profiles.begin();
it != profiles.end(); ++it) {
@@ -127,8 +127,8 @@ std::string ChromeDevToolsHttpHandlerDelegate::GetFrontendResource(
std::string ChromeDevToolsHttpHandlerDelegate::GetPageThumbnailData(
const GURL& url) {
- for (chrome::BrowserIterator it; !it.done(); it.Next()) {
- Profile* profile = (*it)->profile();
+ for (auto* browser : *BrowserList::GetInstance()) {
+ Profile* profile = browser->profile();
scoped_refptr<history::TopSites> top_sites =
TopSitesFactory::GetForProfile(profile);
if (!top_sites)
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/download/download_status_updater_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698