chrome/browser/custom_home_pages_table_model.cc - Issue 1644773003: Remove BrowserIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_home_pages_table_model.cc

Issue 1644773003: Remove BrowserIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-desktop-1

Patch Set: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/custom_home_pages_table_model.cc

diff --git a/chrome/browser/custom_home_pages_table_model.cc b/chrome/browser/custom_home_pages_table_model.cc

index c34bf4b258c0e30bcf64c3929aab8d2ca29cb6e9..0b35feb5155e305c0a3fd00d4a27e26b008f31cc 100644

--- a/chrome/browser/custom_home_pages_table_model.cc

+++ b/chrome/browser/custom_home_pages_table_model.cc

@@ -14,7 +14,6 @@

#include "chrome/browser/history/history_service_factory.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

-#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/settings_window_manager.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

@@ -188,8 +187,7 @@ void CustomHomePagesTableModel::SetToCurrentlyOpenPages() {

// Add tabs from appropriate browser windows.

int add_index = 0;

- for (chrome::BrowserIterator it; !it.done(); it.Next()) {

- Browser* browser = *it;

+ for (auto* browser : *BrowserList::GetInstance()) {

if (!ShouldIncludeBrowser(browser))

continue;