Remove BrowserIterator

chrome/browser/devtools/devtools_window.cc

Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index e64dafc12a955e4692efb576cd80ea093bf991fd..2bc3201eee08b2bad717d34b975c13d98a6595e6 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -21,7 +21,6 @@
 #include "chrome/browser/task_management/web_contents_tags.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
-#include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_window.h"
@@ -76,11 +75,11 @@ bool FindInspectedBrowserAndTabIndex(
   if (!inspected_web_contents)
     return false;
 
-  for (chrome::BrowserIterator it; !it.done(); it.Next()) {
-    int tab_index = it->tab_strip_model()->GetIndexOfWebContents(
+  for (auto* browser_it : *BrowserList::GetInstance()) {

[sky, 2016/01/28 16:58:12]

With the auto browser_it is rather confusing. _it implies the type is an
iterator, but that isn't right. I believe you went with browser_it here to avoid
conflicts with the browser in param. Maybe rename that to found_browser or
something? Or rename to b like you did elsewhere.
Alternatively if you use Browser* rather than auto* it's clearer. 

[scottmg, 2016/01/28 17:36:28]

Done.

+    int tab_index = browser_it->tab_strip_model()->GetIndexOfWebContents(
         inspected_web_contents);
     if (tab_index != TabStripModel::kNoTab) {
-      *browser = *it;
+      *browser = browser_it;
       *tab = tab_index;
       return true;
     }