Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/browser/ui/browser_tab_strip_tracker.cc

Issue 1644773003: Remove BrowserIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@host-desktop-1
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_tab_strip_tracker.h" 5 #include "chrome/browser/ui/browser_tab_strip_tracker.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/browser_iterator.h"
10 #include "chrome/browser/ui/browser_list.h" 9 #include "chrome/browser/ui/browser_list.h"
11 #include "chrome/browser/ui/browser_tab_strip_tracker_delegate.h" 10 #include "chrome/browser/ui/browser_tab_strip_tracker_delegate.h"
12 #include "chrome/browser/ui/tabs/tab_strip_model.h" 11 #include "chrome/browser/ui/tabs/tab_strip_model.h"
13 12
14 BrowserTabStripTracker::BrowserTabStripTracker( 13 BrowserTabStripTracker::BrowserTabStripTracker(
15 TabStripModelObserver* tab_strip_model_observer, 14 TabStripModelObserver* tab_strip_model_observer,
16 BrowserTabStripTrackerDelegate* delegate, 15 BrowserTabStripTrackerDelegate* delegate,
17 BrowserListObserver* browser_list_observer) 16 BrowserListObserver* browser_list_observer)
18 : tab_strip_model_observer_(tab_strip_model_observer), 17 : tab_strip_model_observer_(tab_strip_model_observer),
19 delegate_(delegate), 18 delegate_(delegate),
(...skipping 11 matching lines...) Expand all
31 30
32 void BrowserTabStripTracker::Init(InitWith init_with) { 31 void BrowserTabStripTracker::Init(InitWith init_with) {
33 BrowserList::AddObserver(this); 32 BrowserList::AddObserver(this);
34 33
35 base::AutoReset<bool> restter(&is_processing_initial_browsers_, true); 34 base::AutoReset<bool> restter(&is_processing_initial_browsers_, true);
36 if (init_with == InitWith::BROWSERS_IN_ACTIVE_DESKTOP) { 35 if (init_with == InitWith::BROWSERS_IN_ACTIVE_DESKTOP) {
37 for (Browser* browser : *BrowserList::GetInstance()) 36 for (Browser* browser : *BrowserList::GetInstance())
38 MaybeTrackBrowser(browser); 37 MaybeTrackBrowser(browser);
39 } else { 38 } else {
40 DCHECK(InitWith::ALL_BROWERS == init_with); 39 DCHECK(InitWith::ALL_BROWERS == init_with);
41 for (chrome::BrowserIterator it; !it.done(); it.Next()) 40 for (auto* browser : *BrowserList::GetInstance())
42 MaybeTrackBrowser(*it); 41 MaybeTrackBrowser(browser);
43 } 42 }
44 } 43 }
45 44
46 void BrowserTabStripTracker::StopObservingAndSendOnBrowserRemoved() { 45 void BrowserTabStripTracker::StopObservingAndSendOnBrowserRemoved() {
47 Browsers current_browsers; 46 Browsers current_browsers;
48 current_browsers.swap(browsers_observing_); 47 current_browsers.swap(browsers_observing_);
49 48
50 for (Browser* browser : current_browsers) { 49 for (Browser* browser : current_browsers) {
51 browser->tab_strip_model()->RemoveObserver(tab_strip_model_observer_); 50 browser->tab_strip_model()->RemoveObserver(tab_strip_model_observer_);
52 if (browser_list_observer_) 51 if (browser_list_observer_)
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 browser->tab_strip_model()->RemoveObserver(tab_strip_model_observer_); 88 browser->tab_strip_model()->RemoveObserver(tab_strip_model_observer_);
90 89
91 if (browser_list_observer_) 90 if (browser_list_observer_)
92 browser_list_observer_->OnBrowserRemoved(browser); 91 browser_list_observer_->OnBrowserRemoved(browser);
93 } 92 }
94 93
95 void BrowserTabStripTracker::OnBrowserSetLastActive(Browser* browser) { 94 void BrowserTabStripTracker::OnBrowserSetLastActive(Browser* browser) {
96 if (browser_list_observer_) 95 if (browser_list_observer_)
97 browser_list_observer_->OnBrowserSetLastActive(browser); 96 browser_list_observer_->OnBrowserSetLastActive(browser);
98 } 97 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_list.cc ('k') | chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698