Remove BrowserIterator

chrome/browser/lifetime/browser_close_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/lifetime/browser_close_manager.h"
 
+#include <algorithm>
+#include <iterator>
+#include <vector>
+
 #include "build/build_config.h"
 #include "chrome/browser/background/background_mode_manager.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "content/public/browser/web_contents.h"
 
 namespace {
 
 // Navigates a browser window for |profile|, creating one if necessary, to the
@@ skipping 23 matching lines @@
     // Tell everyone that we are shutting down.
     browser_shutdown::SetTryingToQuit(true);
     CloseBrowsers();
     return;
   }
   TryToCloseBrowsers();
 }
 
 void BrowserCloseManager::CancelBrowserClose() {
   browser_shutdown::SetTryingToQuit(false);
-  for (chrome::BrowserIterator it; !it.done(); it.Next()) {
-    it->ResetBeforeUnloadHandlers();
+  for (auto* browser : *BrowserList::GetInstance()) {
+    browser->ResetBeforeUnloadHandlers();
   }
 }
 
 void BrowserCloseManager::TryToCloseBrowsers() {
   // If all browser windows can immediately be closed, fall out of this loop and
   // close the browsers. If any browser window cannot be closed, temporarily
   // stop closing. CallBeforeUnloadHandlers prompts the user and calls
   // OnBrowserReportCloseable with the result. If the user confirms the close,
   // this will trigger TryToCloseBrowsers to try again.
-  for (chrome::BrowserIterator it; !it.done(); it.Next()) {
-    if (it->CallBeforeUnloadHandlers(
+  for (auto* browser : *BrowserList::GetInstance()) {
+    if (browser->CallBeforeUnloadHandlers(
             base::Bind(&BrowserCloseManager::OnBrowserReportCloseable, this))) {
-      current_browser_ = *it;
+      current_browser_ = browser;
       return;
     }
   }
   CheckForDownloadsInProgress();
 }
 
 void BrowserCloseManager::OnBrowserReportCloseable(bool proceed) {
   if (!current_browser_)
     return;
 
@@ skipping 59 matching lines @@
   // exit can restore all browsers open before exiting.
   ProfileManager::ShutdownSessionServices();
 #endif
   if (!browser_shutdown::IsTryingToQuit()) {
     BackgroundModeManager* background_mode_manager =
         g_browser_process->background_mode_manager();
     if (background_mode_manager)
       background_mode_manager->SuspendBackgroundMode();
   }
 
+  // Make a copy of the BrowserList to simplify the case where we need to
+  // destroy a Browser during the loop.
+  std::vector<Browser*> browser_list_copy;
+  std::copy(BrowserList::GetInstance()->begin(),
+            BrowserList::GetInstance()->end(),
+            std::back_inserter(browser_list_copy));
+
   bool session_ending =
       browser_shutdown::GetShutdownType() == browser_shutdown::END_SESSION;
-  for (scoped_ptr<chrome::BrowserIterator> it_ptr(
-           new chrome::BrowserIterator());
-       !it_ptr->done();) {
-    Browser* browser = **it_ptr;
+
+  for (auto* browser : browser_list_copy) {
     browser->window()->Close();
-    if (!session_ending) {
-      it_ptr->Next();
-    } else {
+    if (session_ending) {
       // This path is hit during logoff/power-down. In this case we won't get
       // a final message and so we force the browser to be deleted.
       // Close doesn't immediately destroy the browser
       // (Browser::TabStripEmpty() uses invoke later) but when we're ending the
       // session we need to make sure the browser is destroyed now. So, invoke
       // DestroyBrowser to make sure the browser is deleted and cleanup can
       // happen.
       while (browser->tab_strip_model()->count())
         delete browser->tab_strip_model()->GetWebContentsAt(0);
       browser->window()->DestroyBrowser();
-      it_ptr.reset(new chrome::BrowserIterator());
-      if (!it_ptr->done() && browser == **it_ptr) {
-        // Destroying the browser should have removed it from the browser list.
-        // We should never get here.
-        NOTREACHED();
-        return;
-      }
+      // Destroying the browser should have removed it from the browser list.
+      DCHECK(BrowserList::GetInstance()->end() ==
+             std::find(BrowserList::GetInstance()->begin(),
+                       BrowserList::GetInstance()->end(), browser));
     }
   }
 }