Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/protobuf2/protobuf.gyp

Issue 164477: Suppress RTTI in protobuf2, now that RTTI is disabled on Mac and Linux (r2330... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf2/protobuf.gyp
===================================================================
--- third_party/protobuf2/protobuf.gyp (revision 23303)
+++ third_party/protobuf2/protobuf.gyp (working copy)
@@ -73,6 +73,18 @@
'src/src/google/protobuf/compiler/parser.cc',
],
+ 'conditions': [
+ ['OS != "win"', {
+ # src/src/google/protobuf/generated_message_reflection.h can figure
+ # out whether RTTI is enabled or disabled via compiler-defined macros
+ # when building with MSVC. For other compilers, this macro must be
+ # defined to suppress the use of dynamic_cast<>, which requires RTTI.
+ 'defines': [
+ 'GOOGLE_PROTOBUF_NO_RTTI',
+ ],
+ }],
+ ],
+
'include_dirs': [
'.',
'src/src',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698