third_party/WebKit/LayoutTests/virtual/media-gpu-accelerated/http/tests/media/media-source/README.txt - Issue 1644763002: Add virtual layout test for GPU accelerated decoding.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/media-gpu-accelerated/http/tests/media/media-source/README.txt

Issue 1644763002: Add virtual layout test for GPU accelerated decoding. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, fix tests, tweak approach Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/android/http/tests/media/media-source/mediasource-config-change-mp4-v-framesize-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 OVERVIEW OF MEDIA-GPU-ACCELERATED TESTS

	2

	3 The media-gpu-accelerated prefix is common to a handful of virtual tests that
	chcunningham 2016/07/16 00:57:51 Note to self - fix this comment if we stick with o Note to self - fix this comment if we stick with one test (likely) chcunningham 2016/07/16 19:02:59 Done. Show quoted text On 2016/07/16 00:57:51, chcunningham wrote: > Note to self - fix this comment if we stick with one test (likely) Done.
	4 need extra flags perform hardware accelerated video decoding on android bots.

	5

	6 TODO(chcunningham): Explore enabling hardware acceleration for desktop bots.

	7 Non-android bots do not currently test with proprietary codecs, which translates

	8 to no hardware acceleration.

	9

	10 Android only runs a small subset of layout tests (see SmokeTests file), so

	11 for now we specify the full paths of the tests we use in SmokeTests to minimize

	12 the penalty for desktop bots.

	13

	14 These tests all add the same flag:

	15 --use-gpu-in-tests

	16

	17 Layout tests generally run using Mesa (see http://crrev.com/23868030) to

	18 to produce more stable output for pixel layout tests when running on different

	19 devices. However, Mesa is not compatible with android's SurfaceTexture,

	20 used in in HW accelerated video decoding (H264 in mp4). We specify

	21 use-gpu-in-tests to override the MesaGL default.

	22

	23

	24 WHY ADD THESE TESTS TO SMOKETESTS
	chcunningham 2016/07/16 00:57:51 Note to self - CL description is probably a better Note to self - CL description is probably a better place for this. chcunningham 2016/07/16 19:02:59 Done. Show quoted text On 2016/07/16 00:57:51, chcunningham wrote: > Note to self - CL description is probably a better place for this. Done.
	25

	26 mediasource-config-change-mp4-av-video-framesize.html:

	27 This test simulates an interesting adaptive playback scenario by reconfiguring

	28 the size of the video midstream. Config changes test the flushing and

	29 reconfiguration of Android's MediaCodec (historically problematic).

	30

	31 mediasource-config-change-mp4-av-audio-bitrate.html:

	32 Android's audio driver is distinct from desktop platforms so this test was

	33 chosen as interesting test for the audio path to cover basic/variable-bitrate

	34 audio playback.

	35

	36 mediasource-config-change-mp4-v-framerate.html:

	37 This test simulates an interesting adaptive playback by varying the framerate of

	38 the video midstream. Its also nice coverage of video-without-audio playback.

OLD	NEW