Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1644753002: Make base work on iOS (Closed)

Created:
4 years, 11 months ago by abarth-chromium
Modified:
4 years, 10 months ago
Reviewers:
jamesr, abarth
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make base work on iOS This patch will let us synchronize the version of base between mojo.git and flutter/engine.git. R=jamesr@chromium.org, jamesr Committed: https://chromium.googlesource.com/external/mojo/+/c3fedd057ee51b68a0963f1bd0acd26d606b8a9b

Patch Set 1 #

Patch Set 2 : Passes gn gen on iOS #

Patch Set 3 : cast #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M base/BUILD.gn View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M base/debug/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M base/debug/stack_trace_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/logging.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M base/time/time.h View 1 chunk +1 line, -1 line 0 comments Download
M base/time/time_mac.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
abarth-chromium
4 years, 11 months ago (2016-01-27 22:06:23 UTC) #1
jamesr
lgtm
4 years, 11 months ago (2016-01-27 22:18:34 UTC) #2
abarth
Looks like we're missing some files. /me will update that patch.
4 years, 11 months ago (2016-01-27 22:25:21 UTC) #4
abarth
Ready for review again.
4 years, 10 months ago (2016-01-28 23:22:19 UTC) #5
jamesr
lgtm
4 years, 10 months ago (2016-01-28 23:31:30 UTC) #6
abarth-chromium
4 years, 10 months ago (2016-01-28 23:46:04 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
c3fedd057ee51b68a0963f1bd0acd26d606b8a9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698