Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1644743002: [mb] Add missing GN args for MSan (Closed)

Created:
4 years, 11 months ago by Oliver Chang
Modified:
4 years, 11 months ago
CC:
chromium-reviews, inferno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mb] Add missing GN args for MSan TBR=phajdan.jr@chromium.org R=mmoroz@chromium.org BUG=581762 Committed: https://crrev.com/d522ce55d6f397d087c500f057b3990c35489bbe Cr-Commit-Position: refs/heads/master@{#371957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Oliver Chang
ptal, simple change.
4 years, 11 months ago (2016-01-27 21:32:29 UTC) #1
mmoroz
lgtm
4 years, 11 months ago (2016-01-27 21:33:12 UTC) #2
inferno
lgtm
4 years, 11 months ago (2016-01-27 21:35:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644743002/1
4 years, 11 months ago (2016-01-27 21:36:43 UTC) #6
Oliver Chang
Unchecking the commit, since this can't landed yet until the recipe side changes are in. ...
4 years, 11 months ago (2016-01-27 21:39:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644743002/1
4 years, 11 months ago (2016-01-28 00:30:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 01:44:22 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 02:05:10 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d522ce55d6f397d087c500f057b3990c35489bbe
Cr-Commit-Position: refs/heads/master@{#371957}

Powered by Google App Engine
This is Rietveld 408576698