Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1644703002: Disable deprecated Skia xfermodes (Closed)

Created:
4 years, 11 months ago by robertphillips
Modified:
4 years, 11 months ago
Reviewers:
f(malita), reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable deprecated Skia xfermodes This is a companion to https://codereview.chromium.org/1645633003/ (Hide SkPixelXorXfermode from Chrome) Committed: https://crrev.com/583be684fbad6f0c013ebe7e7b186c589386a926 Cr-Commit-Position: refs/heads/master@{#371905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
robertphillips
4 years, 11 months ago (2016-01-27 19:40:57 UTC) #3
f(malita)
lgtm
4 years, 11 months ago (2016-01-27 20:45:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644703002/1
4 years, 11 months ago (2016-01-27 21:36:42 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-27 22:39:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644703002/1
4 years, 11 months ago (2016-01-27 22:45:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 22:53:40 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/583be684fbad6f0c013ebe7e7b186c589386a926 Cr-Commit-Position: refs/heads/master@{#371905}
4 years, 11 months ago (2016-01-27 22:55:00 UTC) #14
robertphillips
4 years, 10 months ago (2016-01-28 14:41:13 UTC) #15
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1641213002/ by robertphillips@google.com.

The reason for reverting is: Going to go a different direction with this..

Powered by Google App Engine
This is Rietveld 408576698