Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1644673002: Handle local files better in server mode (Closed)

Created:
4 years, 10 months ago by vsm
Modified:
4 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle local files better in server mode We're already serving sources from the original directory (for source maps). This lets us serve other resources as well. Makes it simpler to run angular todo and other apps with xhr'ed data. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/c1aad7af74cfa7f76ca85e98357fb80aad62dfff

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M lib/src/server/server.dart View 1 1 chunk +8 lines, -5 lines 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/wrappers.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 10 months ago (2016-01-27 18:30:34 UTC) #3
Jennifer Messerly
server mode ಠ_ಠ ;) Code change LGTM tho, w/ a suggestion (I think there should ...
4 years, 10 months ago (2016-01-27 20:50:02 UTC) #4
vsm
4 years, 10 months ago (2016-01-27 22:03:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c1aad7af74cfa7f76ca85e98357fb80aad62dfff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698