Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1644663003: Fix CollectSampleAPI test flakiness. (Closed)

Created:
4 years, 11 months ago by alph
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, yurys
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix CollectSampleAPI test flakiness. There might be more native functions at root node, e.g. b.CreateDoubleResultArray TBR=bmeurer@chromium.org Committed: https://crrev.com/4bf8bf784fca5fc33265a615e785a8af460782e9 Cr-Commit-Position: refs/heads/master@{#33564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M test/cctest/test-cpu-profiler.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
4 years, 11 months ago (2016-01-27 19:45:52 UTC) #2
yurys
lgtm
4 years, 11 months ago (2016-01-27 19:58:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644663003/1
4 years, 11 months ago (2016-01-27 20:00:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 20:25:01 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 20:26:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bf8bf784fca5fc33265a615e785a8af460782e9
Cr-Commit-Position: refs/heads/master@{#33564}

Powered by Google App Engine
This is Rietveld 408576698