Issue 164466: Merge 22431 - This fixes the npapiresponseheaders layout test, which started ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164466: Merge 22431 - This fixes the npapiresponseheaders layout test, which started ... (Closed)

Created:
11 years, 4 months ago by Mark Larson

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Merge 22431 - This fixes the npapiresponseheaders layout test, which started failing after my CL 22369. When a plugin stream load finishes it deletes the corresponding client information maintained by WebPluginImpl. We were referencing this structure after a call to DidFinishLoading on the resource client which caused this issue. This fixes bug http://code.google.com/p/chromium/issues/detail?id=18392 Bug=18392 Test=Covered by layout tests Review URL: http://codereview.chromium.org/160596 TBR=ananta@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23295

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	MM	webkit/glue/webplugin_impl.cc	View		2 chunks	+8 lines, -6 lines	0 comments	Download
	M	webkit/tools/layout_tests/test_expectations.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 1 (0 generated)