Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1644653002: [Tracing] Update sync_id to be string type for clock sync (Closed)

Created:
4 years, 11 months ago by Zhen Wang
Modified:
4 years, 11 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, darin-cc_chromium.org, jam, vmpstr+watch_chromium.org, nednguyen, charliea (OOO until 10-5), rnephew (Reviews Here)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Tracing] Update sync_id to be string type for clock sync The sync_id was int. This CL changes its type to string so that it is more flexible and consistent with DevTools API's preference. Now the tracing controller uses base::GenerateGUID() to generate the ID. BUG=542390 Committed: https://crrev.com/d0e022849450bcb65cb27a3f50d116bfe3635d5d Cr-Commit-Position: refs/heads/master@{#371964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M base/trace_event/tracing_agent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/tracing_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/battor_power_trace_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/battor_power_trace_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tracing/power_tracing_agent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tracing/power_tracing_agent.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 5 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Zhen Wang
ptal
4 years, 11 months ago (2016-01-27 17:29:23 UTC) #3
oystein (OOO til 10th of July)
lgtm
4 years, 11 months ago (2016-01-28 00:41:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644653002/1
4 years, 11 months ago (2016-01-28 00:54:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 02:09:18 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 02:11:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0e022849450bcb65cb27a3f50d116bfe3635d5d
Cr-Commit-Position: refs/heads/master@{#371964}

Powered by Google App Engine
This is Rietveld 408576698