Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1644633007: Marks KeyboardCode as extensible (Closed)

Created:
4 years, 10 months ago by sky
Modified:
4 years, 10 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Marks KeyboardCode as extensible This is currently necessary as windows may supply values not in the enum list. Without extensible a validation error is generated, so that you can't type ':' among others. BUG=582279 TEST=none R=yzshen@chromium.org TBR=yzshen@chromium.org Committed: https://crrev.com/e0cf3d50850c18d0db327a088db89e073c01f964 Cr-Commit-Position: refs/heads/master@{#372234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/mus/public/interfaces/input_key_codes.mojom View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 10 months ago (2016-01-29 00:31:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644633007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644633007/1
4 years, 10 months ago (2016-01-29 00:33:33 UTC) #3
yzshen1
lgtm
4 years, 10 months ago (2016-01-29 00:36:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 01:04:26 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 01:05:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0cf3d50850c18d0db327a088db89e073c01f964
Cr-Commit-Position: refs/heads/master@{#372234}

Powered by Google App Engine
This is Rietveld 408576698