Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1644603002: Adding missing explicit to HandleScope ctors (Closed)

Created:
4 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding missing explicit to HandleScope ctors R=verwaest@chromium.org BUG= Committed: https://crrev.com/fd20f1659d092badd8e1b37a25e75a3ecf474efb Cr-Commit-Position: refs/heads/master@{#33557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/v8.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 11 months ago (2016-01-27 14:17:33 UTC) #1
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-27 15:02:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644603002/1
4 years, 11 months ago (2016-01-27 15:03:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 15:05:28 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 15:05:49 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fd20f1659d092badd8e1b37a25e75a3ecf474efb
Cr-Commit-Position: refs/heads/master@{#33557}

Powered by Google App Engine
This is Rietveld 408576698