Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1644593003: Fix FakePortAllocator to keep reference to TransportContext. (Closed)

Created:
4 years, 11 months ago by Sergey Ulanov
Modified:
4 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix FakePortAllocator to keep reference to TransportContext. Previously FakePortAllocator didn't keep reference to TransportContext which was causing it to be destructed prematurely and crashing remoting_perftests. Committed: https://crrev.com/19cd0018c69864050567700e88f02c2280b4995c Cr-Commit-Position: refs/heads/master@{#371980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M remoting/test/fake_port_allocator.h View 2 chunks +6 lines, -2 lines 0 comments Download
M remoting/test/fake_port_allocator.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
4 years, 11 months ago (2016-01-28 01:49:24 UTC) #2
Jamie
lgtm
4 years, 11 months ago (2016-01-28 01:58:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644593003/1
4 years, 11 months ago (2016-01-28 02:08:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 03:07:31 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 03:09:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19cd0018c69864050567700e88f02c2280b4995c
Cr-Commit-Position: refs/heads/master@{#371980}

Powered by Google App Engine
This is Rietveld 408576698