third_party/WebKit/Source/modules/notifications/NotificationAction.idl - Issue 1644573002: Notification actions may have an icon url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationAction.idl

Issue 1644573002: Notification actions may have an icon url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/platform_notification_data.h ('K') | « content/public/common/platform_notification_data.h ('k') | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('j') | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationAction.idl

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationAction.idl b/third_party/WebKit/Source/modules/notifications/NotificationAction.idl

index 044c054a291201fa013a6ce5d5ff1c3de325ef84..c99ee9fef90b461e3430e6cc1b9e353bb0ba3288 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationAction.idl

+++ b/third_party/WebKit/Source/modules/notifications/NotificationAction.idl

@@ -7,4 +7,5 @@

dictionary NotificationAction {

required DOMString action;

required DOMString title;

+ [RuntimeEnabled=NotificationExperimental] USVString icon;

Peter Beverloo 2016/01/27 13:24:45 nit: since this bit us in the past, have you consi

Michael van Ouwerkerk 2016/01/27 14:24:32 I did consider it, but wanted to get this out for

};