Notification actions may have an icon url.

third_party/WebKit/Source/modules/notifications/NotificationData.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/notifications/NotificationData.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/SerializedScriptValue.h"
 #include "bindings/core/v8/SerializedScriptValueFactory.h"
 #include "core/dom/ExecutionContext.h"
 #include "modules/notifications/Notification.h"
 #include "modules/notifications/NotificationOptions.h"
 #include "modules/vibration/NavigatorVibration.h"
-#include "platform/RuntimeEnabledFeatures.h"
 #include "platform/weborigin/KURL.h"
 
 namespace blink {
 namespace {
 
 WebNotificationData::Direction toDirectionEnumValue(const String& direction)
 {
     if (direction == "ltr")
         return WebNotificationData::DirectionLeftToRight;
     if (direction == "rtl")
@@ skipping 15 matching lines @@
     WebNotificationData webData;
 
     webData.title = title;
     webData.direction = toDirectionEnumValue(options.dir());
     webData.lang = options.lang();
     webData.body = options.body();
     webData.tag = options.tag();
 
     KURL iconUrl;
 
-    // TODO(peter): Apply the appropriate CORS checks on the |iconUrl|.
     if (options.hasIcon() && !options.icon().isEmpty()) {
         iconUrl = executionContext->completeURL(options.icon());
         if (!iconUrl.isValid())
             iconUrl = KURL();
     }
 
     webData.icon = iconUrl;
     webData.vibrate = NavigatorVibration::sanitizeVibrationPattern(options.vibrate());
     webData.silent = options.silent();
     webData.requireInteraction = options.requireInteraction();
@@ skipping 13 matching lines @@
 
     const size_t maxActions = Notification::maxActions();
     for (const NotificationAction& action : options.actions()) {
         if (actions.size() >= maxActions)
             break;
 
         WebNotificationAction webAction;
         webAction.action = action.action();
         webAction.title = action.title();
 
+        KURL iconUrl;
+        if (action.hasIcon() && !action.icon().isEmpty()) {
+            iconUrl = executionContext->completeURL(action.icon());
+            if (!iconUrl.isValid())
+                iconUrl = KURL();
+        }
+        webAction.icon = iconUrl;

[Peter Beverloo, 2016/01/27 17:14:23]

PTAL at third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

(An invalid icon test might be useful, too)

[Michael van Ouwerkerk, 2016/02/01 14:39:23]

Done.

+
         actions.append(webAction);
     }
 
     webData.actions = actions;
 
     return webData;
 }
 
 } // namespace blink