Notification actions may have an icon url.

third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/notifications/NotificationData.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/modules/v8/UnionTypesModules.h"
 #include "core/testing/NullExecutionContext.h"
 #include "modules/notifications/Notification.h"
 #include "modules/notifications/NotificationOptions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/CurrentTime.h"
 #include "wtf/HashMap.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 namespace {
 
 const char kNotificationTitle[] = "My Notification";
 
 const char kNotificationDir[] = "rtl";
 const char kNotificationLang[] = "nl";
 const char kNotificationBody[] = "Hello, world";
 const char kNotificationTag[] = "my_tag";
 const char kNotificationIcon[] = "https://example.com/icon.png";
+const char kNotificationIconInvalid[] = "https://invalid:icon:url";
 const unsigned kNotificationVibration[] = { 42, 10, 20, 30, 40 };
 const unsigned long long kNotificationTimestamp = 621046800ull;
 const bool kNotificationSilent = false;
 const bool kNotificationRequireInteraction = true;
 
 const char kNotificationActionAction[] = "my_action";
 const char kNotificationActionTitle[] = "My Action";
+const char kNotificationActionIcon[] = "https://example.com/action_icon.png";
 
 const unsigned kNotificationVibrationUnnormalized[] = { 10, 1000000, 50, 42 };
 const int kNotificationVibrationNormalized[] = { 10, 10000, 50 };
 
 class NotificationDataTest : public ::testing::Test {
 public:
     void SetUp() override
     {
         m_executionContext = adoptRefWillBeNoop(new NullExecutionContext());
     }
@@ skipping 11 matching lines @@
         vibrationPattern.append(kNotificationVibration[i]);
 
     UnsignedLongOrUnsignedLongSequence vibrationSequence;
     vibrationSequence.setUnsignedLongSequence(vibrationPattern);
 
     HeapVector<NotificationAction> actions;
     for (size_t i = 0; i < Notification::maxActions(); ++i) {
         NotificationAction action;
         action.setAction(kNotificationActionAction);
         action.setTitle(kNotificationActionTitle);
+        action.setIcon(kNotificationActionIcon);
 
         actions.append(action);
     }
 
     NotificationOptions options;
     options.setDir(kNotificationDir);
     options.setLang(kNotificationLang);
     options.setBody(kNotificationBody);
     options.setTag(kNotificationTag);
     options.setIcon(kNotificationIcon);
     options.setVibrate(vibrationSequence);
     options.setTimestamp(kNotificationTimestamp);
     options.setSilent(kNotificationSilent);
     options.setRequireInteraction(kNotificationRequireInteraction);
     options.setActions(actions);
 
     // TODO(peter): Test |options.data| and |notificationData.data|.
 
     TrackExceptionState exceptionState;
     WebNotificationData notificationData = createWebNotificationData(executionContext(), kNotificationTitle, options, exceptionState);
     ASSERT_FALSE(exceptionState.hadException());
 
     EXPECT_EQ(kNotificationTitle, notificationData.title);
 
     EXPECT_EQ(WebNotificationData::DirectionRightToLeft, notificationData.direction);
     EXPECT_EQ(kNotificationLang, notificationData.lang);
     EXPECT_EQ(kNotificationBody, notificationData.body);
     EXPECT_EQ(kNotificationTag, notificationData.tag);
 
-    // TODO(peter): Test notificationData.icon when ExecutionContext::completeURL() works in this test.
+    // TODO(peter): Test WebNotificationData.icon and WebNotificationAction.icon when ExecutionContext::completeURL() works in this test.
 
     ASSERT_EQ(vibrationPattern.size(), notificationData.vibrate.size());
     for (size_t i = 0; i < vibrationPattern.size(); ++i)
         EXPECT_EQ(vibrationPattern[i], static_cast<unsigned>(notificationData.vibrate[i]));
 
     EXPECT_EQ(kNotificationTimestamp, notificationData.timestamp);
     EXPECT_EQ(kNotificationSilent, notificationData.silent);
     EXPECT_EQ(kNotificationRequireInteraction, notificationData.requireInteraction);
     EXPECT_EQ(actions.size(), notificationData.actions.size());
+    for (const auto& action : notificationData.actions) {
+        EXPECT_EQ(kNotificationActionAction, action.action);
+        EXPECT_EQ(kNotificationActionTitle, action.title);
+    }
 }
 
 TEST_F(NotificationDataTest, SilentNotificationWithVibration)
 {
     Vector<unsigned> vibrationPattern;
     for (size_t i = 0; i < WTF_ARRAY_LENGTH(kNotificationVibration); ++i)
         vibrationPattern.append(kNotificationVibration[i]);
 
     UnsignedLongOrUnsignedLongSequence vibrationSequence;
     vibrationSequence.setUnsignedLongSequence(vibrationPattern);
 
     NotificationOptions options;
     options.setVibrate(vibrationSequence);
     options.setSilent(true);
 
     TrackExceptionState exceptionState;
     WebNotificationData notificationData = createWebNotificationData(executionContext(), kNotificationTitle, options, exceptionState);
     ASSERT_TRUE(exceptionState.hadException());
 
     EXPECT_EQ("Silent notifications must not specify vibration patterns.", exceptionState.message());
 }
 
-TEST_F(NotificationDataTest, InvalidIconUrl)
+TEST_F(NotificationDataTest, InvalidIconUrls)
 {
+    HeapVector<NotificationAction> actions;
+    for (size_t i = 0; i < Notification::maxActions(); ++i) {
+        NotificationAction action;
+        action.setAction(kNotificationActionAction);
+        action.setTitle(kNotificationActionTitle);
+        action.setIcon(kNotificationIconInvalid);
+        actions.append(action);
+    }
+
     NotificationOptions options;
-    options.setIcon("https://invalid:icon:url");
+    options.setIcon(kNotificationIconInvalid);
+    options.setActions(actions);
 
     TrackExceptionState exceptionState;
     WebNotificationData notificationData = createWebNotificationData(executionContext(), kNotificationTitle, options, exceptionState);
     ASSERT_FALSE(exceptionState.hadException());
 
     EXPECT_TRUE(notificationData.icon.isEmpty());
+    for (const auto& action : notificationData.actions)
+        EXPECT_TRUE(action.icon.isEmpty());
 }
 
 TEST_F(NotificationDataTest, VibrationNormalization)
 {
     Vector<unsigned> unnormalizedPattern;
     for (size_t i = 0; i < WTF_ARRAY_LENGTH(kNotificationVibrationUnnormalized); ++i)
         unnormalizedPattern.append(kNotificationVibrationUnnormalized[i]);
 
     UnsignedLongOrUnsignedLongSequence vibrationSequence;
     vibrationSequence.setUnsignedLongSequence(unnormalizedPattern);
@@ skipping 71 matching lines @@
     ASSERT_EQ(Notification::maxActions(), notificationData.actions.size());
 
     for (size_t i = 0; i < Notification::maxActions(); ++i) {
         WebString expectedAction = String::number(i);
         EXPECT_EQ(expectedAction, notificationData.actions[i].action);
     }
 }
 
 } // namespace
 } // namespace blink