Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

Issue 1644553002: Constructing an RTCPeerConnection with expired certificates should throw an exception. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase /w master. Updated test to generate expired certificate and verify exception is thrown Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 class RTCPeerConnection final 64 class RTCPeerConnection final
65 : public EventTargetWithInlineData 65 : public EventTargetWithInlineData
66 , public WebRTCPeerConnectionHandlerClient 66 , public WebRTCPeerConnectionHandlerClient
67 , public ActiveScriptWrappable 67 , public ActiveScriptWrappable
68 , public ActiveDOMObject { 68 , public ActiveDOMObject {
69 DEFINE_WRAPPERTYPEINFO(); 69 DEFINE_WRAPPERTYPEINFO();
70 USING_GARBAGE_COLLECTED_MIXIN(RTCPeerConnection); 70 USING_GARBAGE_COLLECTED_MIXIN(RTCPeerConnection);
71 USING_PRE_FINALIZER(RTCPeerConnection, dispose); 71 USING_PRE_FINALIZER(RTCPeerConnection, dispose);
72 public: 72 public:
73 // TODO(hbos): Create with expired RTCCertificate should fail, see crbug.com /565278.
74 static RTCPeerConnection* create(ExecutionContext*, const Dictionary&, const Dictionary&, ExceptionState&); 73 static RTCPeerConnection* create(ExecutionContext*, const Dictionary&, const Dictionary&, ExceptionState&);
75 ~RTCPeerConnection() override; 74 ~RTCPeerConnection() override;
76 75
77 ScriptPromise createOffer(ScriptState*, const RTCOfferOptions&); 76 ScriptPromise createOffer(ScriptState*, const RTCOfferOptions&);
78 ScriptPromise createOffer(ScriptState*, RTCSessionDescriptionCallback*, RTCP eerConnectionErrorCallback*, const Dictionary&); 77 ScriptPromise createOffer(ScriptState*, RTCSessionDescriptionCallback*, RTCP eerConnectionErrorCallback*, const Dictionary&);
79 78
80 ScriptPromise createAnswer(ScriptState*, const RTCAnswerOptions&); 79 ScriptPromise createAnswer(ScriptState*, const RTCAnswerOptions&);
81 ScriptPromise createAnswer(ScriptState*, RTCSessionDescriptionCallback*, RTC PeerConnectionErrorCallback*, const Dictionary&); 80 ScriptPromise createAnswer(ScriptState*, RTCSessionDescriptionCallback*, RTC PeerConnectionErrorCallback*, const Dictionary&);
82 81
83 ScriptPromise setLocalDescription(ScriptState*, const RTCSessionDescriptionI nit&); 82 ScriptPromise setLocalDescription(ScriptState*, const RTCSessionDescriptionI nit&);
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 Member<AsyncMethodRunner<RTCPeerConnection>> m_dispatchScheduledEventRunner; 209 Member<AsyncMethodRunner<RTCPeerConnection>> m_dispatchScheduledEventRunner;
211 HeapVector<Member<EventWrapper>> m_scheduledEvents; 210 HeapVector<Member<EventWrapper>> m_scheduledEvents;
212 211
213 bool m_stopped; 212 bool m_stopped;
214 bool m_closed; 213 bool m_closed;
215 }; 214 };
216 215
217 } // namespace blink 216 } // namespace blink
218 217
219 #endif // RTCPeerConnection_h 218 #endif // RTCPeerConnection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698