third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h - Issue 1644553002: Constructing an RTCPeerConnection with expired certificates should throw an exception.

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

Issue 1644553002: Constructing an RTCPeerConnection with expired certificates should throw an exception. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check expiration at RTCPeerConnection::create, not at parseConfiguration Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 class VoidCallback;	57 class VoidCallback;

58	58

59 class RTCPeerConnection final	59 class RTCPeerConnection final

60 : public RefCountedGarbageCollectedEventTargetWithInlineData<RTCPeerConnecti on>	60 : public RefCountedGarbageCollectedEventTargetWithInlineData<RTCPeerConnecti on>

61 , public WebRTCPeerConnectionHandlerClient	61 , public WebRTCPeerConnectionHandlerClient

62 , public ActiveDOMObject {	62 , public ActiveDOMObject {

63 REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(RTCPeerConnection);	63 REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(RTCPeerConnection);

64 DEFINE_WRAPPERTYPEINFO();	64 DEFINE_WRAPPERTYPEINFO();

65 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCPeerConnection);	65 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCPeerConnection);

66 public:	66 public:

67 // TODO(hbos): Create with expired RTCCertificate should fail, see crbug.com /565278.

68 static RTCPeerConnection* create(ExecutionContext*, const Dictionary&, const Dictionary&, ExceptionState&);	67 static RTCPeerConnection* create(ExecutionContext*, const Dictionary&, const Dictionary&, ExceptionState&);

69 ~RTCPeerConnection() override;	68 ~RTCPeerConnection() override;

70	69

71 void createOffer(ExecutionContext, RTCSessionDescriptionCallback, RTCError Callback*, const Dictionary&, ExceptionState&);	70 void createOffer(ExecutionContext, RTCSessionDescriptionCallback, RTCError Callback*, const Dictionary&, ExceptionState&);

72	71

73 void createAnswer(ExecutionContext, RTCSessionDescriptionCallback, RTCErro rCallback*, const Dictionary&, ExceptionState&);	72 void createAnswer(ExecutionContext, RTCSessionDescriptionCallback, RTCErro rCallback*, const Dictionary&, ExceptionState&);

74	73

75 void setLocalDescription(ExecutionContext, RTCSessionDescription, VoidCall back, RTCErrorCallback, ExceptionState&);	74 void setLocalDescription(ExecutionContext, RTCSessionDescription, VoidCall back, RTCErrorCallback, ExceptionState&);

76 RTCSessionDescription* localDescription();	75 RTCSessionDescription* localDescription();

77	76

(...skipping 128 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
206 Member<AsyncMethodRunner<RTCPeerConnection>> m_dispatchScheduledEventRunner;	205 Member<AsyncMethodRunner<RTCPeerConnection>> m_dispatchScheduledEventRunner;

207 HeapVector<Member<EventWrapper>> m_scheduledEvents;	206 HeapVector<Member<EventWrapper>> m_scheduledEvents;

208	207

209 bool m_stopped;	208 bool m_stopped;

210 bool m_closed;	209 bool m_closed;

211 };	210 };

212	211

213 } // namespace blink	212 } // namespace blink

214	213

215 #endif // RTCPeerConnection_h	214 #endif // RTCPeerConnection_h

OLD	NEW