Constructing an RTCPeerConnection with expired certificates should throw an exception.

third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 18 matching lines @@
  */
 
 #include "modules/mediastream/RTCPeerConnection.h"
 
 #include "bindings/core/v8/ArrayValue.h"
 #include "bindings/core/v8/ExceptionMessages.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/Nullable.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/modules/v8/V8RTCCertificate.h"
+#include "core/dom/DOMTimeStamp.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/VoidCallback.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/FrameLoaderClient.h"
 #include "modules/crypto/CryptoResultImpl.h"
 #include "modules/mediastream/MediaConstraintsImpl.h"
@@ skipping 20 matching lines @@
 #include "public/platform/WebRTCConfiguration.h"
 #include "public/platform/WebRTCDataChannelHandler.h"
 #include "public/platform/WebRTCDataChannelInit.h"
 #include "public/platform/WebRTCICECandidate.h"
 #include "public/platform/WebRTCKeyParams.h"
 #include "public/platform/WebRTCOfferOptions.h"
 #include "public/platform/WebRTCSessionDescription.h"
 #include "public/platform/WebRTCSessionDescriptionRequest.h"
 #include "public/platform/WebRTCStatsRequest.h"
 #include "public/platform/WebRTCVoidRequest.h"
+#include "wtf/CurrentTime.h"
 
 namespace blink {
 
 namespace {
 
 static bool throwExceptionIfSignalingStateClosed(RTCPeerConnection::SignalingState state, ExceptionState& exceptionState)
 {
     if (state == RTCPeerConnection::SignalingStateClosed) {
         exceptionState.throwDOMException(InvalidStateError, "The RTCPeerConnection's signalingState is 'closed'.");
         return true;
@@ skipping 234 matching lines @@
 {
     if (mediaConstraints.isObject())
         UseCounter::count(context, UseCounter::RTCPeerConnectionConstructorConstraints);
     else
         UseCounter::count(context, UseCounter::RTCPeerConnectionConstructorCompliant);
 
     RTCConfiguration* configuration = parseConfiguration(rtcConfiguration, exceptionState);
     if (exceptionState.hadException())
         return 0;
 
+    // Make sure no certificates have expired.
+    if (configuration->numberOfCertificates() > 0) {
+        DOMTimeStamp now = convertSecondsToDOMTimeStamp(currentTime());

[hta - Chromium, 2016/01/29 07:15:14]

My usual caveat on depending on currentTime for stuff that you want to test. It
seems that wtf/CurrentTime() *is* injectable, but no current tests inject it, so
it's probably not likely to work well if you manipulate it for tests of this
function.

[hbos_chromium, 2016/04/20 11:08:58]

The ability to generate expired certificates landed, so I could add a test
without injecting. So the js test is like a real usage case in regards to
timing.

+        for (size_t i = 0; i < configuration->numberOfCertificates(); ++i) {
+            DOMTimeStamp expires = configuration->certificate(i)->expires();
+            if (expires <= now) {
+                exceptionState.throwDOMException(InvalidStateError, "Expired certificate(s).");
+                return 0;
+            }
+        }
+    }
+
     MediaErrorState mediaErrorState;
     WebMediaConstraints constraints = MediaConstraintsImpl::create(mediaConstraints, mediaErrorState);
     if (mediaErrorState.hadException()) {
         mediaErrorState.raiseException(exceptionState);
         return 0;
     }
 
     RTCPeerConnection* peerConnection = new RTCPeerConnection(context, configuration, constraints, exceptionState);
     peerConnection->suspendIfNeeded();
     if (exceptionState.hadException())
@@ skipping 715 matching lines @@
     visitor->trace(m_localStreams);
     visitor->trace(m_remoteStreams);
     visitor->trace(m_dataChannels);
     visitor->trace(m_dispatchScheduledEventRunner);
     visitor->trace(m_scheduledEvents);
     RefCountedGarbageCollectedEventTargetWithInlineData<RTCPeerConnection>::trace(visitor);
     ActiveDOMObject::trace(visitor);
 }
 
 } // namespace blink