Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/misc/resources/iframe-ch-with-picture-removal.php

Issue 1644503002: Fix an outdated picture removal test and comment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/misc/resources/iframe-ch-with-picture-removal.php
diff --git a/third_party/WebKit/LayoutTests/http/tests/misc/resources/iframe-ch-with-picture-removal.php b/third_party/WebKit/LayoutTests/http/tests/misc/resources/iframe-ch-with-picture-removal.php
index 6123e201d4cc85f89ad44a1fd645f6c0c4e18fe2..0fa34e577d7fe8a460bbb20e6d1104438359d3f5 100644
--- a/third_party/WebKit/LayoutTests/http/tests/misc/resources/iframe-ch-with-picture-removal.php
+++ b/third_party/WebKit/LayoutTests/http/tests/misc/resources/iframe-ch-with-picture-removal.php
@@ -6,9 +6,8 @@
<script>
window.addEventListener("message", function (message) {
var pic = document.getElementById("pic");
- pic.removeChild(pic.childNodes[0]);
- // TODO(yoav): this should trigger a load, but doesn't. See https://crbug.com/418903
- success();
+ pic.removeChild(document.getElementById("firstsource"));
+ setTimeout(function(){fail(4);}, 200);
});
var fail = function(num) {
@@ -37,7 +36,7 @@
}
</script>
<picture id=pic>
- <source sizes="50vw" media="(min-width: 800px)" srcset="image-checks-for-width.php?rw=400">
- <source sizes="50vw" srcset="image-checks-for-width.php?rw=300">
+ <source sizes="50vw" id="firstsource" media="(min-width: 800px)" srcset="image-checks-for-width.php?rw=400">
+ <source sizes="40vw" srcset="image-checks-for-width.php?rw=320">
<img onerror="error()" onload="load()">
</picture>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698