Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1644503002: Fix an outdated picture removal test and comment (Closed)

Created:
4 years, 10 months ago by Yoav Weiss
Modified:
4 years, 10 months ago
Reviewers:
Eric Willigers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an outdated picture removal test and comment One of the Client Hints tests contained an outdated comment about mutation related issue that was since solved, as well as a workaround for that issue. This CL removes the comment and makes sure that the test doesn't work around that no-longer-relevant bug. BUG= Committed: https://crrev.com/605adccc5336fbc83fb41fc6516c0e64eb3a0f79 Cr-Commit-Position: refs/heads/master@{#371909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/misc/resources/iframe-ch-with-picture-removal.php View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yoav Weiss
4 years, 10 months ago (2016-01-27 09:41:03 UTC) #2
Eric Willigers
lgtm
4 years, 10 months ago (2016-01-27 22:58:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644503002/1
4 years, 10 months ago (2016-01-27 22:59:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 23:08:35 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 23:09:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/605adccc5336fbc83fb41fc6516c0e64eb3a0f79
Cr-Commit-Position: refs/heads/master@{#371909}

Powered by Google App Engine
This is Rietveld 408576698