Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/core/dom/ScriptLoader.h

Issue 1644483002: Let notifyScriptLoadError() handle already detached ScriptLoaders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add explanatory comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ScriptRunner.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 // Helper functions used by our parent classes. 79 // Helper functions used by our parent classes.
80 void didNotifySubtreeInsertionsToDocument(); 80 void didNotifySubtreeInsertionsToDocument();
81 void childrenChanged(); 81 void childrenChanged();
82 void handleSourceAttribute(const String& sourceUrl); 82 void handleSourceAttribute(const String& sourceUrl);
83 void handleAsyncAttribute(); 83 void handleAsyncAttribute();
84 84
85 virtual bool isReady() const { return m_pendingScript && m_pendingScript->is Ready(); } 85 virtual bool isReady() const { return m_pendingScript && m_pendingScript->is Ready(); }
86 86
87 // Clears the connection to the PendingScript (and Element and Resource). 87 // Clears the connection to the PendingScript (and Element and Resource).
88 void detach(); 88 void detach();
89 #if !ENABLE(OILPAN)
90 bool isDetached() const { return !m_pendingScript; }
91 #endif
89 92
90 protected: 93 protected:
91 ScriptLoader(Element*, bool createdByParser, bool isEvaluated); 94 ScriptLoader(Element*, bool createdByParser, bool isEvaluated);
92 95
93 private: 96 private:
94 bool ignoresLoadRequest() const; 97 bool ignoresLoadRequest() const;
95 bool isScriptForEventSupported() const; 98 bool isScriptForEventSupported() const;
96 void logScriptMimetype(ScriptResource*, LocalFrame*, String); 99 void logScriptMimetype(ScriptResource*, LocalFrame*, String);
97 100
98 bool fetchScript(const String& sourceUrl, FetchRequest::DeferOption); 101 bool fetchScript(const String& sourceUrl, FetchRequest::DeferOption);
(...skipping 21 matching lines...) Expand all
120 bool m_willExecuteWhenDocumentFinishedParsing : 1; 123 bool m_willExecuteWhenDocumentFinishedParsing : 1;
121 bool m_forceAsync : 1; 124 bool m_forceAsync : 1;
122 bool m_willExecuteInOrder : 1; 125 bool m_willExecuteInOrder : 1;
123 }; 126 };
124 127
125 ScriptLoader* toScriptLoaderIfPossible(Element*); 128 ScriptLoader* toScriptLoaderIfPossible(Element*);
126 129
127 } // namespace blink 130 } // namespace blink
128 131
129 #endif // ScriptLoader_h 132 #endif // ScriptLoader_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ScriptRunner.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698