Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issue 1644383002: PPC: [for-in] Ensure that we learn from deopts within for-in loop bodies. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [for-in] Ensure that we learn from deopts within for-in loop bodies. Port 0637f5f64c3bc5d8fc930e65730b7d86cce7a74c Original commit message: If we deoptimize from TurboFan or Crankshaft into the body of a for-in loop and that for-in mode then switches to slow mode (i.e. has to call %ForInFilter), we have to record that feedback, because otherwise we might actually OSR into that loop assuming that it's fast mode still, or even worse recompile the function later when we call it again w/o having rerun the for-in loop in fullcodegen from the beginning (where was previously the only place we could learn). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:3650 LOG=n Committed: https://crrev.com/0dc1e186e08627054a1113d247c6a5579e67b5c3 Cr-Commit-Position: refs/heads/master@{#33617}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 10 months ago (2016-01-29 17:14:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644383002/1
4 years, 10 months ago (2016-01-29 17:14:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-29 17:36:19 UTC) #5
michael_dawson
On 2016/01/29 17:36:19, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 10 months ago (2016-01-29 18:11:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644383002/1
4 years, 10 months ago (2016-01-29 19:29:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 19:31:20 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 19:31:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dc1e186e08627054a1113d247c6a5579e67b5c3
Cr-Commit-Position: refs/heads/master@{#33617}

Powered by Google App Engine
This is Rietveld 408576698