Issue 164437: Fix a strict aliasing bug in x64 release build....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164437: Fix a strict aliasing bug in x64 release build.... (Closed)

Created:
11 years, 4 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix a strict aliasing bug in x64 release build. When this function is fully inlined in a release build, the assignment to *result is reorder after the read. Thus the rest of the code ends up using the wrong value and crashes shortly after.

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/handles.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

11 years, 4 months ago (2009-08-12 23:05:48 UTC) #3

I am going to keep working on this (I had a patch that isn't working, but if I
can make it work it should be cleaner).

On 2009/08/12 23:02:59, agl wrote:
>

Expand Messages | Collapse Messages