Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1644283002: Revert of [turbofan] Add the StackSlot operator to turbofan. (Closed)

Created:
4 years, 10 months ago by ahaas
Modified:
4 years, 10 months ago
Reviewers:
titzer, v8-arm-ports, v8-ppc-ports, v8-mips-ports
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Add the StackSlot operator to turbofan. (patchset #4 id:60001 of https://codereview.chromium.org/1645653002/ ) Reason for revert: problems on Mac64 Original issue's description: > [turbofan] Add the StackSlot operator to turbofan. > > The StackSlot operator allows to allocate a spill slot on the stack. We > are going to use this operator to pass floats through pointers to c > functions, which we need for floating point rounding in the case where > the architecture does not provide rounding instructions. > > R=titzer@chromium.org, v8-arm-ports@googlegroups.com, v8-ppc-ports@googlegroups.com, v8-mips-ports@googlegroups.com > > Committed: https://crrev.com/7a693437787090d62d937b862e29521debcc5223 > Cr-Commit-Position: refs/heads/master@{#33600} TBR=titzer@chromium.org,v8-arm-ports@googlegroups.com,v8-mips-ports@googlegroups.com,v8-ppc-ports@googlegroups.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/11f7c2e63c98783650ef1fc9f01160cf2910e44e Cr-Commit-Position: refs/heads/master@{#33601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -226 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +2 lines, -13 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/machine-operator.cc View 3 chunks +0 lines, -26 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 6 chunks +5 lines, -11 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
ahaas
Created Revert of [turbofan] Add the StackSlot operator to turbofan.
4 years, 10 months ago (2016-01-29 08:18:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644283002/1
4 years, 10 months ago (2016-01-29 08:18:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 08:18:44 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 08:19:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11f7c2e63c98783650ef1fc9f01160cf2910e44e
Cr-Commit-Position: refs/heads/master@{#33601}

Powered by Google App Engine
This is Rietveld 408576698