Issue 164421: Add |#undef LOG| to code that may see WebKit's and Chromium's LOGs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164421: Add |#undef LOG| to code that may see WebKit's and Chromium's LOGs (Closed)

Created:
11 years, 4 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
levin, darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add a few more |#undef LOG| directives to code that might see both WebKit's and Chromium's definitions of LOG. This is necessary after WebKit r47092 exposed its LOG in a few more places. BUG=0 TEST=WebKit Canaries come back to life Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23221

Patch Set 1 #

Total comments: 3

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -4 lines)			Patch
M	webkit/glue/bookmarklet_unittest.cc	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	webkit/tools/test_shell/event_sending_controller.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	webkit/tools/test_shell/test_worker/test_worker_main.cc	View	1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 4 months ago (2009-08-12 21:47:21 UTC) #3

http://codereview.chromium.org/164421/diff/1/2
File webkit/glue/bookmarklet_unittest.cc (right):

http://codereview.chromium.org/164421/diff/1/2#newcode5
Line 5: #include "config.h"
i think we should just remove config.h from this file instead.

http://codereview.chromium.org/164421/diff/1/4
File webkit/tools/test_shell/test_webview_delegate.cc (right):

http://codereview.chromium.org/164421/diff/1/4#newcode9
Line 9: #include "config.h"
looks like we can just remove the config.h include also.

http://codereview.chromium.org/164421/diff/1/3
File webkit/tools/test_shell/test_worker/test_worker_main.cc (right):

http://codereview.chromium.org/164421/diff/1/3#newcode5
Line 5: #include "config.h"
can we remove config.h instead?

Expand Messages | Collapse Messages