Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1644183002:
Disable flakey Mp3FastSeekIntegrationTest.FastSeekAccuracy_MP3 test on MAC OSX. (Closed)
|
Created:
4 years, 10 months ago by chcunningham Modified:
4 years, 10 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable flakey Mp3FastSeekIntegrationTest.FastSeekAccuracy_MP3 test on MAC OSX.
TODO: root cause and re-enable.
BUG=571898
Committed: https://crrev.com/4358ab2b12338f51ad537bab9c9d922816f94fab
Cr-Commit-Position: refs/heads/master@{#372248}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Try to appease windows build. #Messages
Total messages: 18 (7 generated)
chcunningham@chromium.org changed reviewers: + wolenetz@chromium.org
lgtm I'll check the CQ bit shortly. Note: I assume, from the code, that the no-toc mp3 file *isn't* flaky, right? https://codereview.chromium.org/1644183002/diff/1/media/test/pipeline_integra... File media/test/pipeline_integration_test.cc (right): https://codereview.chromium.org/1644183002/diff/1/media/test/pipeline_integra... media/test/pipeline_integration_test.cc:1351: // TODO(CHCUNNINGHAM): Re-enable for OSX once 1% flakiness is root caused. really minor nit. in future, lower case the contents of TODO(x)
The CQ bit was checked by wolenetz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644183002/1
On 2016/01/28 23:26:46, wolenetz wrote: > lgtm > I'll check the CQ bit shortly. > Note: I assume, from the code, that the no-toc mp3 file *isn't* flaky, right? Right, all the logs i've seen its just this one test. And I've confirmed the failure of the first TEST_P does not prevent the others from running. > > https://codereview.chromium.org/1644183002/diff/1/media/test/pipeline_integra... > File media/test/pipeline_integration_test.cc (right): > > https://codereview.chromium.org/1644183002/diff/1/media/test/pipeline_integra... > media/test/pipeline_integration_test.cc:1351: // TODO(CHCUNNINGHAM): Re-enable > for OSX once 1% flakiness is root caused. > really minor nit. in future, lower case the contents of TODO(x)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
https://codereview.chromium.org/1644183002/diff/1/media/test/pipeline_integra... File media/test/pipeline_integration_test.cc (right): https://codereview.chromium.org/1644183002/diff/1/media/test/pipeline_integra... media/test/pipeline_integration_test.cc:1353: #if !defined(OS_MACOSX) windows bot is complaining. macro substitution is probably messing with the expected result here. I suggest partitioning CBRSeeks into two cases (with/without TOC), ditto for VBR for consistency, then simply ifdef'ing the whole CBR has_TOC INSTANTIATE_TEST_CASE_P(....)...; section
chcunningham@google.com changed reviewers: + chcunningham@google.com
https://codereview.chromium.org/1644183002/diff/1/media/test/pipeline_integra... File media/test/pipeline_integration_test.cc (right): https://codereview.chromium.org/1644183002/diff/1/media/test/pipeline_integra... media/test/pipeline_integration_test.cc:1351: // TODO(CHCUNNINGHAM): Re-enable for OSX once 1% flakiness is root caused. On 2016/01/28 23:26:46, wolenetz wrote: > really minor nit. in future, lower case the contents of TODO(x) Acknowledged. https://codereview.chromium.org/1644183002/diff/1/media/test/pipeline_integra... media/test/pipeline_integration_test.cc:1353: #if !defined(OS_MACOSX) On 2016/01/28 23:45:35, wolenetz wrote: > windows bot is complaining. macro substitution is probably messing with the > expected result here. I suggest partitioning CBRSeeks into two cases > (with/without TOC), ditto for VBR for consistency, then simply ifdef'ing the > whole CBR has_TOC INSTANTIATE_TEST_CASE_P(....)...; section Done.
The CQ bit was checked by chcunningham@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from wolenetz@chromium.org Link to the patchset: https://codereview.chromium.org/1644183002/#ps20001 (title: "Try to appease windows build.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644183002/20001
Still lgtm. Thanks!
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable flakey Mp3FastSeekIntegrationTest.FastSeekAccuracy_MP3 test on MAC OSX. TODO: root cause and re-enable. BUG=571898 ========== to ========== Disable flakey Mp3FastSeekIntegrationTest.FastSeekAccuracy_MP3 test on MAC OSX. TODO: root cause and re-enable. BUG=571898 Committed: https://crrev.com/4358ab2b12338f51ad537bab9c9d922816f94fab Cr-Commit-Position: refs/heads/master@{#372248} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4358ab2b12338f51ad537bab9c9d922816f94fab Cr-Commit-Position: refs/heads/master@{#372248} |
