Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1644103002: [interpreter] Move BytecodeGraphBuilder::Environment. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-cleanup-graph-builder-iterator
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Move BytecodeGraphBuilder::Environment. This moves the definition of the Environment class into the compilation unit because it is only used there and not needed outside, the header doesn't need to expose it. R=rmcilroy@chromium.org Committed: https://crrev.com/9bc3a2f150f8008aa7d7e16c59fa21718a1d6b55 Cr-Commit-Position: refs/heads/master@{#33605}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -85 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 1 chunk +0 lines, -85 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 10 months ago (2016-01-28 19:04:07 UTC) #1
rmcilroy
lgtm
4 years, 10 months ago (2016-01-29 07:18:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644103002/20001
4 years, 10 months ago (2016-01-29 09:10:43 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 09:26:41 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 09:27:15 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bc3a2f150f8008aa7d7e16c59fa21718a1d6b55
Cr-Commit-Position: refs/heads/master@{#33605}

Powered by Google App Engine
This is Rietveld 408576698