android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java - Issue 16441002: [Android WebView] Fix error description setting for provisional load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java

Issue 16441002: [Android WebView] Fix error description setting for provisional load (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments addressed Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java

index d9497e7f878cb59b1461e6b03039c338437c29d3..8e6ce4240bcc75daa9ee62508edfcbd6657a55ea 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java

@@ -134,6 +134,6 @@ public class ClientOnReceivedErrorTest extends AwTestBase {

assertEquals(ErrorCodeConversionHelper.ERROR_UNKNOWN,

onReceivedErrorHelper.getErrorCode());

assertEquals(url, onReceivedErrorHelper.getFailingUrl());

- assertNotNull(onReceivedErrorHelper.getDescription());

+ assertFalse(onReceivedErrorHelper.getDescription().isEmpty());

}

« no previous file with comments | « no previous file | android_webview/renderer/aw_content_renderer_client.cc » ('j') | android_webview/renderer/aw_content_renderer_client.cc » ('J')