Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 1644093002: Set the SDK analysis options in analyzer_cli (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Brian Wilkerson
4 years, 10 months ago (2016-01-28 18:46:21 UTC) #2
Jennifer Messerly
for what it's worth, LGTM :)
4 years, 10 months ago (2016-01-28 19:12:45 UTC) #4
scheglov
LGTM
4 years, 10 months ago (2016-01-28 19:13:18 UTC) #5
vsm
lgtm
4 years, 10 months ago (2016-01-29 13:36:18 UTC) #6
Brian Wilkerson
Committed patchset #1 (id:1) manually as 348b79b8ece768ca9e55f2eb18683af7c520ec64 (presubmit successful).
4 years, 10 months ago (2016-01-29 15:42:33 UTC) #8
vsm
On 2016/01/29 15:42:33, Brian Wilkerson wrote: > Committed patchset #1 (id:1) manually as > 348b79b8ece768ca9e55f2eb18683af7c520ec64 ...
4 years, 10 months ago (2016-02-01 16:24:56 UTC) #9
Brian Wilkerson
4 years, 10 months ago (2016-02-01 16:34:25 UTC) #10
Message was sent while issue was closed.
>  do we need something similar in the analyzer server code as well?

It's more complex in the server code because different projects can have
different options set. That means that we will (potentially) need two SDK
contexts, one using strong mode and another using spec mode to analyze the SDK.
I've started working on some of the support necessary to allow that.

Powered by Google App Engine
This is Rietveld 408576698