Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: content/public/common/notification_resources.h

Issue 1644083002: Fetch notification action icons and pass them through in resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ActionIconBlink
Patch Set: Rebase. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_tests.gypi ('k') | content/public/common/notification_resources.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/notification_resources.h
diff --git a/content/public/common/notification_resources.h b/content/public/common/notification_resources.h
index 8986f96bee6fb08f88c7e2eba83d5f41f62cf16b..23c54773e1392e8d95e1d4f09eb80a61f277858f 100644
--- a/content/public/common/notification_resources.h
+++ b/content/public/common/notification_resources.h
@@ -5,17 +5,25 @@
#ifndef CONTENT_PUBLIC_COMMON_NOTIFICATION_RESOURCES_H_
#define CONTENT_PUBLIC_COMMON_NOTIFICATION_RESOURCES_H_
+#include <vector>
+
#include "content/common/content_export.h"
#include "third_party/skia/include/core/SkBitmap.h"
namespace content {
// Structure to hold the resources associated with a Web Notification.
-// TODO(mvanouwerkerk): Add resources for e.g. action icons - crbug.com/581336.
struct CONTENT_EXPORT NotificationResources {
+ NotificationResources();
+ ~NotificationResources();
+
// Main icon for the notification. The bitmap may be empty if the developer
// did not provide an icon, or fetching of the icon failed.
SkBitmap notification_icon;
+
+ // Icons for the actions. A bitmap may be empty if the developer did not
+ // provide an icon, or fetching of the icon failed.
+ std::vector<SkBitmap> action_icons;
};
} // namespace content
« no previous file with comments | « content/content_tests.gypi ('k') | content/public/common/notification_resources.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698