Desktop Share Audio User Permission

In this CL, we extend API chooseDesktopMedia by adding one
more source type "audio".

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

Current functionality is behind flag
--enable-audio-support-for-desktop-share.

Design Doc is at https://goo.gl/yIJ08b
This CL is implementation of Use Case 4.a
BUG=557222
Committed: https://crrev.com/1ab5937e528db4ba1a1d361ac39f079a17b6f0d4
Cr-Commit-Position: refs/heads/master@{#373576}

[Ken Rockot(use gerrit already), 2016-01-28 19:25:54]

rockot@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-01-28 19:25:54]

https://codereview.chromium.org/1644073002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/desktop_capture.json (right):

https://codereview.chromium.org/1644073002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/desktop_capture.json:37: "name":
"request_audio_permission",
Proper naming scheme for object fields would be requestAudioPermission

[qiangchen, 2016-01-29 00:41:13]

Description was changed from

==========
API Change Proposal

BUG=
==========

to

==========
In this CL, we extend API chooseDesktopMedia by adding one more source type
"audio". 

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

BUG=557222
==========

[qiangchen, 2016-01-29 00:41:27]

Description was changed from

==========
In this CL, we extend API chooseDesktopMedia by adding one more source type
"audio". 

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

BUG=557222
==========

to

==========
In this CL, we extend API chooseDesktopMedia by adding one 
more source type "audio". 

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

BUG=557222
==========

[qiangchen, 2016-01-29 00:42:21]

Description was changed from

==========
In this CL, we extend API chooseDesktopMedia by adding one 
more source type "audio". 

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

BUG=557222
==========

to

==========
In this CL, we extend API chooseDesktopMedia by adding one 
more source type "audio". 

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

Current functionality is behind flag 
--enable-audio-support-for-desktop-share.

BUG=557222
==========

[qiangchen, 2016-01-29 01:02:15]

Patchset #3 (id:40001) has been deleted

[qiangchen, 2016-01-29 01:06:17]

Just found, we can actually add a enum value for parameter sources rather than
adding another parameter to achieve the goal, which will not change the
"signature" of chooseDesktopMedia. 

Finish the UI on picker window and pass the permission value to
desktop_capture_access_handler.

PTAL Thanks.

[qiangchen, 2016-01-29 18:14:40]

Description was changed from

==========
In this CL, we extend API chooseDesktopMedia by adding one 
more source type "audio". 

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

Current functionality is behind flag 
--enable-audio-support-for-desktop-share.

BUG=557222
==========

to

==========
In this CL, we extend API chooseDesktopMedia by adding one 
more source type "audio". 

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

Current functionality is behind flag 
--enable-audio-support-for-desktop-share.

Design Doc is at https://goo.gl/yIJ08b
This CL is implementation of Use Case 4.a
BUG=557222
==========

[qiangchen, 2016-01-29 18:20:32]

qiangchen@chromium.org changed reviewers:
+ niklase@chromium.org

[qiangchen, 2016-01-29 18:20:33]

Hi, Niklas:

    I updated design doc by adding use cases, so the full picture will be
clearer to everyone, especially the ones not familiar with desktop capture.

     This CL is the implementation of 4.a

Qiang

[Ken Rockot(use gerrit already), 2016-01-29 22:20:15]

I like this API better :)

https://codereview.chromium.org/1644073002/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1644073002/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:13529: +        Also share audio (only
support for screen share)
It would be nice if we could only show this checkbox when prompting for screen
share. Is that possible? Having a checkbox that essentially says "I might not
mean anything" is pretty weird. WDYT?

[Ken Rockot(use gerrit already), 2016-01-29 22:22:38]

On 2016/01/29 at 22:20:15, Ken Rockot wrote:
> I like this API better :)
> 
>
https://codereview.chromium.org/1644073002/diff/60001/chrome/app/generated_re...
> File chrome/app/generated_resources.grd (right):
> 
>
https://codereview.chromium.org/1644073002/diff/60001/chrome/app/generated_re...
> chrome/app/generated_resources.grd:13529: +        Also share audio (only
support for screen share)
> It would be nice if we could only show this checkbox when prompting for screen
share. Is that possible? Having a checkbox that essentially says "I might not
mean anything" is pretty weird. WDYT?

I now realize I may have misinterpreted the meaning. Perhaps we do only show it
then, but the API may have requested screen share as well as other sources.

In that case I might still change the text to "Also share audio for screen
share" or something

[qiangchen, 2016-02-02 16:36:42]

Thanks for your review. Replied.

I'll make the checkbox more user friendly, and update snapshots in the design.

https://codereview.chromium.org/1644073002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/desktop_capture.json (right):

https://codereview.chromium.org/1644073002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/desktop_capture.json:37: "name":
"request_audio_permission",
On 2016/01/28 19:25:54, Ken Rockot wrote:
> Proper naming scheme for object fields would be requestAudioPermission

N/A now. Look at Patch 3's json file for new API change, we will simply add a
enum value rather than a base parameter.

https://codereview.chromium.org/1644073002/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1644073002/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:13529: +        Also share audio (only
support for screen share)
On 2016/01/29 22:20:15, Ken Rockot wrote:
> It would be nice if we could only show this checkbox when prompting for screen
> share. Is that possible? Having a checkbox that essentially says "I might not
> mean anything" is pretty weird. WDYT?

Or we may move the checkbox to below the window/screen selection, and depending
on 
what the user select, we enable or disable the checkbox.

In that case, disabling checkbox will show a tooltip explaining why the checkbox
is
disabled.

P.S. We are on the other hand developing the tab sharing, for which audio share
is 
possible.

[qiangchen, 2016-02-02 22:58:28]

qiangchen@chromium.org changed reviewers:
+ msw@chromium.org, nasko@chromium.org, xhwang@chromium.org

[qiangchen, 2016-02-02 22:58:29]

Hi, PTAL, Thanks.

Please mainly focus on your owned files.

msw: Picker Window UI (Mac part will be in another CL) 
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.h 
chrome/browser/ui/cocoa/media_picker/desktop_media_picker_cocoa.mm
  chrome/browser/ui/views/desktop_media_picker_views.cc
  chrome/browser/ui/views/desktop_media_picker_views.h 
chrome/browser/ui/views/desktop_media_picker_views_unittest.cc

xhwang: getUserMedia will handle audio stream for desktop capture.
  chrome/browser/media/desktop_capture_access_handler.cc
  chrome/browser/media/desktop_media_picker.h

nasko: Add one field in DesktopMediaID to record whether audio is permitted or
not.
  content/public/browser/desktop_media_id.h

rockot: ChooseDesktopMedia API modification 
chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
  chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
  chrome/common/extensions/api/desktop_capture.json
  chrome/common/extensions/docs/examples/api/desktopCapture/app.js
  extensions/common/switches.cc
  extensions/common/switches.h

[Ken Rockot(use gerrit already), 2016-02-03 14:22:25]

rockot@chromium.org changed reviewers:
+ xhwang@chromium.orgw
- xhwang@chromium.org

[Ken Rockot(use gerrit already), 2016-02-03 14:22:26]

extensions lgtm

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
(right):

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc:103: bool
has_flag = base::CommandLine::ForCurrentProcess()->HasSwitch(
nit: i don't think there's a need to introduce has_flag here, can you just
assign directly to request_audio?

[qiangchen, 2016-02-03 17:29:13]

qiangchen@chromium.org changed reviewers:
+ xhwang@chromium.org
- xhwang@chromium.orgw

[qiangchen, 2016-02-03 17:41:41]

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
(right):

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc:103: bool
has_flag = base::CommandLine::ForCurrentProcess()->HasSwitch(
On 2016/02/03 14:22:25, Ken Rockot wrote:
> nit: i don't think there's a need to introduce has_flag here, can you just
> assign directly to request_audio?

I think it is better to put it behind the flag, until we complete everything.
Otherwise, theoretically there is a chance web developer could plug in "audio"
in the sources parameter when calling chooseDesktopMedia, and discover a funny
thing that it could make a checkbox visible, but unusable.

[xhwang, 2016-02-03 18:13:32]

xhwang@chromium.org changed reviewers:
+ tommi@chromium.org

[xhwang, 2016-02-03 18:13:32]

xhwang -> tommi since this is WebRTC related change

[msw, 2016-02-03 18:21:56]

https://codereview.chromium.org/1644073002/diff/100001/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1644073002/diff/100001/chrome/app/generated_r...
chrome/app/generated_resources.grd:13532: +        We do not support audio for
window share.
Are these strings approved by PM/UX? "We do not support" sounds really odd...
how about "Audio sharing is not supported for individual windows." or similar?

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/desktop_media_picker_views.cc (right):

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:471: static const size_t
kDialogViewWidth = 600;
You should ensure that the checkbox preferred width is less than this value;
otherwise, the text will get cut off.

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:477: checkbox_ ?
checkbox_->GetPreferredSize().height() : 0;
You need to add an additional views::kPanelVertMargin here for the padding
between the scroll view and the checkbox.

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:499: (checkbox_ ?
checkbox_->GetPreferredSize().height() : 0);
Ditto: You need to add an additional views::kPanelVertMargin here for the
padding between the scroll view and the checkbox.

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:507: rect.width(),
checkbox_->GetHeightForWidth(rect.width()));
Using GetHeightForWidth here, but GetPreferredSize above, is incorrect. The
checkbox should have a single height used for layout.

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:547: if (checkbox_) {
nit: remove curly braces

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:568: // Disable the
checkbox if we cannot support audio for the selected source
nit: trailing period

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:578:
checkbox_->SetTooltipText(base::UTF8ToUTF16(""));
Use base::string16() here instead of base::UTF8ToUTF16("")

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/desktop_media_picker_views.h (right):

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.h:154: views::Checkbox*
checkbox_;
nit: Use more descriptive member names, like |share_audio_checkbox_|.
(update others too? |label_| doesn't impart what it's actually used for)

[qiangchen, 2016-02-03 19:19:02]

Fixed as msw@ pointed out. Thanks.

https://codereview.chromium.org/1644073002/diff/100001/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1644073002/diff/100001/chrome/app/generated_r...
chrome/app/generated_resources.grd:13532: +        We do not support audio for
window share.
On 2016/02/03 18:21:55, msw wrote:
> Are these strings approved by PM/UX? "We do not support" sounds really odd...
> how about "Audio sharing is not supported for individual windows." or similar?

Done.

Can you tell me the approval process for new strings from PM/UX?

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/desktop_media_picker_views.cc (right):

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:471: static const size_t
kDialogViewWidth = 600;
On 2016/02/03 18:21:55, msw wrote:
> You should ensure that the checkbox preferred width is less than this value;
> otherwise, the text will get cut off.

Changed to GetHeightForWidth

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:477: checkbox_ ?
checkbox_->GetPreferredSize().height() : 0;
On 2016/02/03 18:21:55, msw wrote:
> You need to add an additional views::kPanelVertMargin here for the padding
> between the scroll view and the checkbox.

Done.

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:499: (checkbox_ ?
checkbox_->GetPreferredSize().height() : 0);
On 2016/02/03 18:21:55, msw wrote:
> Ditto: You need to add an additional views::kPanelVertMargin here for the
> padding between the scroll view and the checkbox.

Done.

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:507: rect.width(),
checkbox_->GetHeightForWidth(rect.width()));
On 2016/02/03 18:21:55, msw wrote:
> Using GetHeightForWidth here, but GetPreferredSize above, is incorrect. The
> checkbox should have a single height used for layout.

Done.

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:547: if (checkbox_) {
On 2016/02/03 18:21:55, msw wrote:
> nit: remove curly braces

N/A now, as variable name change make it multiple lines.

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:568: // Disable the
checkbox if we cannot support audio for the selected source
On 2016/02/03 18:21:55, msw wrote:
> nit: trailing period

Done.

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:578:
checkbox_->SetTooltipText(base::UTF8ToUTF16(""));
On 2016/02/03 18:21:55, msw wrote:
> Use base::string16() here instead of base::UTF8ToUTF16("")

Done.

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/desktop_media_picker_views.h (right):

https://codereview.chromium.org/1644073002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.h:154: views::Checkbox*
checkbox_;
On 2016/02/03 18:21:55, msw wrote:
> nit: Use more descriptive member names, like |share_audio_checkbox_|.
> (update others too? |label_| doesn't impart what it's actually used for)

Done.

[msw, 2016-02-03 19:34:19]

lgtm with a nit

https://codereview.chromium.org/1644073002/diff/100001/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1644073002/diff/100001/chrome/app/generated_r...
chrome/app/generated_resources.grd:13532: +        We do not support audio for
window share.
On 2016/02/03 19:19:01, qiangchenC wrote:
> On 2016/02/03 18:21:55, msw wrote:
> > Are these strings approved by PM/UX? "We do not support" sounds really
odd...
> > how about "Audio sharing is not supported for individual windows." or
similar?
> 
> Done.
> 
> Can you tell me the approval process for new strings from PM/UX?

Niklas Blum is marked as the pm on issue 557222, he should take a look. I
suppose you don't need specific approvals, but having someone with a designer's
eye review these user-facing strings and ui changes would be good.

https://codereview.chromium.org/1644073002/diff/120001/chrome/browser/ui/view...
File chrome/browser/ui/views/desktop_media_picker_views.cc (right):

https://codereview.chromium.org/1644073002/diff/120001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:562: source.audio_share =
nit: remove conditional above and include it in the statement as:
source.audio_share = audio_share_checkbox_ && audio_share_checkbox_->enabled()
&& audio_share_checkbox_->checked();

[nasko, 2016-02-03 22:11:32]

Rubberstamp LGTM on content/ change.

[qiangchen, 2016-02-03 23:45:10]

https://codereview.chromium.org/1644073002/diff/100001/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1644073002/diff/100001/chrome/app/generated_r...
chrome/app/generated_resources.grd:13532: +        We do not support audio for
window share.
On 2016/02/03 19:34:19, msw wrote:
> On 2016/02/03 19:19:01, qiangchenC wrote:
> > On 2016/02/03 18:21:55, msw wrote:
> > > Are these strings approved by PM/UX? "We do not support" sounds really
> odd...
> > > how about "Audio sharing is not supported for individual windows." or
> similar?
> > 
> > Done.
> > 
> > Can you tell me the approval process for new strings from PM/UX?
> 
> Niklas Blum is marked as the pm on issue 557222, he should take a look. I
> suppose you don't need specific approvals, but having someone with a
designer's
> eye review these user-facing strings and ui changes would be good.

Acknowledged.

https://codereview.chromium.org/1644073002/diff/120001/chrome/browser/ui/view...
File chrome/browser/ui/views/desktop_media_picker_views.cc (right):

https://codereview.chromium.org/1644073002/diff/120001/chrome/browser/ui/view...
chrome/browser/ui/views/desktop_media_picker_views.cc:562: source.audio_share =
On 2016/02/03 19:34:19, msw wrote:
> nit: remove conditional above and include it in the statement as:
> source.audio_share = audio_share_checkbox_ && audio_share_checkbox_->enabled()
> && audio_share_checkbox_->checked(); 

Done.

[tommi (sloooow) - chröme, 2016-02-04 10:48:38]

tommi@chromium.org changed reviewers:
+ guidou@chromium.org

[tommi (sloooow) - chröme, 2016-02-04 10:48:38]

Guido - can you take a look?

[Guido Urdaneta, 2016-02-04 13:00:53]

chrome/browser/media non-owner lgtm

[qiangchen, 2016-02-04 16:42:43]

On 2016/02/04 13:00:53, Guido Urdaneta wrote:
> chrome/browser/media non-owner lgtm

Hi, tommi@

Can you give me a lgtm? You are the owner of files under chrome/browser/media.

[tommi (sloooow) - chröme, 2016-02-04 16:47:40]

rs lgtm - thanks for taking a look guido

[qiangchen, 2016-02-04 18:51:27]

The CQ bit was checked by qiangchen@chromium.org

[qiangchen, 2016-02-04 18:51:28]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
msw@chromium.org, nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1644073002/#ps140001
(title: "Minor Style Change")

[commit-bot: I haz the power, 2016-02-04 18:52:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644073002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644073002/140001

[commit-bot: I haz the power, 2016-02-04 19:05:42]

Description was changed from

==========
In this CL, we extend API chooseDesktopMedia by adding one 
more source type "audio". 

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

Current functionality is behind flag 
--enable-audio-support-for-desktop-share.

Design Doc is at https://goo.gl/yIJ08b
This CL is implementation of Use Case 4.a
BUG=557222
==========

to

==========
In this CL, we extend API chooseDesktopMedia by adding one 
more source type "audio". 

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

Current functionality is behind flag 
--enable-audio-support-for-desktop-share.

Design Doc is at https://goo.gl/yIJ08b
This CL is implementation of Use Case 4.a
BUG=557222
==========

[commit-bot: I haz the power, 2016-02-04 19:05:43]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-02-04 19:07:10]

Description was changed from

==========
In this CL, we extend API chooseDesktopMedia by adding one 
more source type "audio". 

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

Current functionality is behind flag 
--enable-audio-support-for-desktop-share.

Design Doc is at https://goo.gl/yIJ08b
This CL is implementation of Use Case 4.a
BUG=557222
==========

to

==========
In this CL, we extend API chooseDesktopMedia by adding one
more source type "audio".

With that, the window picker will show a checkbox which serves
the purpose as asking user permission for audio share.
If the user checks the checkbox, then we will generate audio
stream.

Current functionality is behind flag
--enable-audio-support-for-desktop-share.

Design Doc is at https://goo.gl/yIJ08b
This CL is implementation of Use Case 4.a
BUG=557222

Committed: https://crrev.com/1ab5937e528db4ba1a1d361ac39f079a17b6f0d4
Cr-Commit-Position: refs/heads/master@{#373576}
==========

[commit-bot: I haz the power, 2016-02-04 19:07:11]

Patchset 7 (id:??) landed as
https://crrev.com/1ab5937e528db4ba1a1d361ac39f079a17b6f0d4
Cr-Commit-Position: refs/heads/master@{#373576}

[Sergey Ulanov, 2016-03-29 18:32:11]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2016-03-29 18:32:12]

https://codereview.chromium.org/1644073002/diff/140001/content/public/browser...
File content/public/browser/desktop_media_id.h (right):

https://codereview.chromium.org/1644073002/diff/140001/content/public/browser...
content/public/browser/desktop_media_id.h:51: bool operator==(const
DesktopMediaID& other) const;
I think you also need to update implementation of these operators to take
audio_share into account.