SkMojo: test linking Skia against the Mojo SDK

SkMojo: test linking Skia against the Mojo SDK

TODO: build on systems other than Linux.

Add mojo_skd to the DEPS.

Add a DM::Via called `mojo-`.

everything is hidden behind the gyp variable `skia_mojo`.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1644043003

Committed: https://skia.googlesource.com/skia/+/7a76f9c8f4de11e51b3495eec0d76be88a12adfa

[hal.canary, 2016-01-28 22:27:13]

Description was changed from

==========
Mojo WIP

BUG=skia:
==========

to

==========
Mojo WIP

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-01-28 22:27:40]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2016-01-28 22:27:41]

compiles, does not link.

[mtklein, 2016-01-29 01:07:38]

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/.gitignore
File experimental/mojo/.gitignore (right):

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/.gitignor...
experimental/mojo/.gitignore:1: Skia.mojom-internal.h
*.mojom*.*?

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojom
File experimental/mojo/Skia.mojom (right):

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojo...
experimental/mojo/Skia.mojom:3: module SkiaMojo;
SkMojo seems like it'll fit well in the rest of our code.

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojo...
experimental/mojo/Skia.mojom:188: float round_rect_left;
It'd be nice to read

Rect rect;
Corner ul;
Corner ur;
...

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojo...
experimental/mojo/Skia.mojom:226: float  matrix_scale_x;
Yes let's definitely factor.  At least Rect and Matrix.

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojo...
experimental/mojo/Skia.mojom:268: float cubic_0_x;
Is this 3 coefficients for 4 cubics, no?  Let's make that clear?

(Alternatively, don't handle drawPatch?  I don't think anyone's calling it.)

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojo...
experimental/mojo/Skia.mojom:443: DefineImage           define_image;
Let's hold off on anything Canvas doesn't actually support.

https://codereview.chromium.org/1644043003/diff/1/gyp/skiamojo.gyp
File gyp/skiamojo.gyp (right):

https://codereview.chromium.org/1644043003/diff/1/gyp/skiamojo.gyp#newcode10
gyp/skiamojo.gyp:10: 'sources': [ '../experimental/mojo/Skia.mojom.cc', ],
There some way to get gyp to generate this dynamically?

[mtklein, 2016-01-29 01:11:16]

This is neat to see how all these things might work, but it represents many,
many decisions made, so I would rather start by landing something much, much
smaller.  E.g.

struct Rect {
   float l;
   float t;
   float r;
   float b;
}

struct FlattenedPicture {
   array<uint8_t> bytes;
}

[hal.canary, 2016-01-29 17:56:07]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 17:56:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644043003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644043003/40001

[commit-bot: I haz the power, 2016-01-29 17:58:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 17:58:24]

Dry run: Try jobs failed on following builders:
  Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-...)

[hal.canary, 2016-01-29 17:58:30]

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/.gitignore
File experimental/mojo/.gitignore (right):

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/.gitignor...
experimental/mojo/.gitignore:1: Skia.mojom-internal.h
On 2016/01/29 at 01:07:38, mtklein wrote:
> *.mojom*.*?

done

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojom
File experimental/mojo/Skia.mojom (right):

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojo...
experimental/mojo/Skia.mojom:3: module SkiaMojo;
On 2016/01/29 at 01:07:38, mtklein wrote:
> SkMojo seems like it'll fit well in the rest of our code.

done

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojo...
experimental/mojo/Skia.mojom:188: float round_rect_left;
On 2016/01/29 at 01:07:38, mtklein wrote:
> It'd be nice to read
> 
> Rect rect;
> Corner ul;
> Corner ur;
> ...

code deleted for now.  I'll add it as I can test it.

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojo...
experimental/mojo/Skia.mojom:226: float  matrix_scale_x;
On 2016/01/29 at 01:07:38, mtklein wrote:
> Yes let's definitely factor.  At least Rect and Matrix.

code deleted for now.  I'll add it as I can test it.

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojo...
experimental/mojo/Skia.mojom:268: float cubic_0_x;
On 2016/01/29 at 01:07:38, mtklein wrote:
> Is this 3 coefficients for 4 cubics, no?  Let's make that clear?
> 
> (Alternatively, don't handle drawPatch?  I don't think anyone's calling it.)

code deleted for now.  I'll add it as I can test it.

https://codereview.chromium.org/1644043003/diff/1/experimental/mojo/Skia.mojo...
experimental/mojo/Skia.mojom:443: DefineImage           define_image;
On 2016/01/29 at 01:07:38, mtklein wrote:
> Let's hold off on anything Canvas doesn't actually support.

code deleted for now.  I'll add it as I can test it.

https://codereview.chromium.org/1644043003/diff/1/gyp/skiamojo.gyp
File gyp/skiamojo.gyp (right):

https://codereview.chromium.org/1644043003/diff/1/gyp/skiamojo.gyp#newcode10
gyp/skiamojo.gyp:10: 'sources': [ '../experimental/mojo/Skia.mojom.cc', ],
On 2016/01/29 at 01:07:38, mtklein wrote:
> There some way to get gyp to generate this dynamically?

I think I've got it now.

[hal.canary, 2016-01-29 17:59:38]

halcanary@google.com changed reviewers:
+ reed@google.com

[hal.canary, 2016-01-29 17:59:39]

first SkMojo CL.

[mtklein, 2016-01-29 18:09:41]

https://codereview.chromium.org/1644043003/diff/40001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1644043003/diff/40001/dm/DMSrcSink.cpp#newcode35
dm/DMSrcSink.cpp:35: #include "SkMojo.mojom.h"
Indent this #include a bit?

https://codereview.chromium.org/1644043003/diff/40001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:1242: Error ViaMojo::draw(const Src& src, SkBitmap* bitmap,
SkWStream* stream, SkString* log) const {
Let's indent the bits inside the #ifdef / #else

https://codereview.chromium.org/1644043003/diff/40001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:1254: auto mojoPicture = SkMojo::FlattenedPicture::New();
While we're getting used to the types, let's write this auto out long-ways.

https://codereview.chromium.org/1644043003/diff/40001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:1257: SkASSERT(mojoPicture.get() && mojoPicture->data);
// TODO: serialize + deserialize FlattenedPicture

https://codereview.chromium.org/1644043003/diff/40001/experimental/mojo/gener...
File experimental/mojo/generate.py (right):

https://codereview.chromium.org/1644043003/diff/40001/experimental/mojo/gener...
experimental/mojo/generate.py:39:
'public/tools/bindings/mojom_parser/bin/linux64/mojom_parser'),
This indentation is weird.  It looks like GetFile takes 3 args.

https://codereview.chromium.org/1644043003/diff/40001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1644043003/diff/40001/gyp/common_conditions.g...
gyp/common_conditions.gypi:15: [ 'skia_mojo_experiment', {'defines': [
'SK_MOJO_EXPERIMENT'] } ],
Let's drop _experiment and _EXPERIMENT.  We know it's an experiment... I don't
want to have to keep typing it or having it in my face.

https://codereview.chromium.org/1644043003/diff/40001/gyp/skiamojo.gyp
File gyp/skiamojo.gyp (right):

https://codereview.chromium.org/1644043003/diff/40001/gyp/skiamojo.gyp#newcode26
gyp/skiamojo.gyp:26: 'target_name': 'skiamojo',
let's be skmojo everywhere

https://codereview.chromium.org/1644043003/diff/40001/gyp/tests.gypi
File gyp/tests.gypi (right):

https://codereview.chromium.org/1644043003/diff/40001/gyp/tests.gypi#newcode26
gyp/tests.gypi:26: 'skiamojo.gyp:skiamojo',
This seems like the wrong place for this.

[hal.canary, 2016-01-29 18:26:06]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 18:26:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644043003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644043003/80001

[hal.canary, 2016-01-29 18:44:25]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 18:44:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644043003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644043003/100001

[hal.canary, 2016-01-29 18:44:50]

https://codereview.chromium.org/1644043003/diff/40001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1644043003/diff/40001/dm/DMSrcSink.cpp#newcode35
dm/DMSrcSink.cpp:35: #include "SkMojo.mojom.h"
On 2016/01/29 at 18:09:40, mtklein wrote:
> Indent this #include a bit?

done

https://codereview.chromium.org/1644043003/diff/40001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:1242: Error ViaMojo::draw(const Src& src, SkBitmap* bitmap,
SkWStream* stream, SkString* log) const {
On 2016/01/29 at 18:09:40, mtklein wrote:
> Let's indent the bits inside the #ifdef / #else

done

https://codereview.chromium.org/1644043003/diff/40001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:1254: auto mojoPicture = SkMojo::FlattenedPicture::New();
On 2016/01/29 at 18:09:40, mtklein wrote:
> While we're getting used to the types, let's write this auto out long-ways.

done

https://codereview.chromium.org/1644043003/diff/40001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:1257: SkASSERT(mojoPicture.get() && mojoPicture->data);
On 2016/01/29 at 18:09:40, mtklein wrote:
> // TODO: serialize + deserialize FlattenedPicture

the todo is done.

https://codereview.chromium.org/1644043003/diff/40001/experimental/mojo/gener...
File experimental/mojo/generate.py (right):

https://codereview.chromium.org/1644043003/diff/40001/experimental/mojo/gener...
experimental/mojo/generate.py:39:
'public/tools/bindings/mojom_parser/bin/linux64/mojom_parser'),
On 2016/01/29 at 18:09:40, mtklein wrote:
> This indentation is weird.  It looks like GetFile takes 3 args.

done

https://codereview.chromium.org/1644043003/diff/40001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1644043003/diff/40001/gyp/common_conditions.g...
gyp/common_conditions.gypi:15: [ 'skia_mojo_experiment', {'defines': [
'SK_MOJO_EXPERIMENT'] } ],
On 2016/01/29 at 18:09:41, mtklein wrote:
> Let's drop _experiment and _EXPERIMENT.  We know it's an experiment... I don't
want to have to keep typing it or having it in my face.

done

https://codereview.chromium.org/1644043003/diff/40001/gyp/skiamojo.gyp
File gyp/skiamojo.gyp (right):

https://codereview.chromium.org/1644043003/diff/40001/gyp/skiamojo.gyp#newcode26
gyp/skiamojo.gyp:26: 'target_name': 'skiamojo',
On 2016/01/29 at 18:09:41, mtklein wrote:
> let's be skmojo everywhere

okay.  done.

https://codereview.chromium.org/1644043003/diff/40001/gyp/tests.gypi
File gyp/tests.gypi (right):

https://codereview.chromium.org/1644043003/diff/40001/gyp/tests.gypi#newcode26
gyp/tests.gypi:26: 'skiamojo.gyp:skiamojo',
On 2016/01/29 at 18:09:41, mtklein wrote:
> This seems like the wrong place for this.

I realizied that when the compile failed.  Moving to dm.gypi, with a conditional
in a better place.

[mtklein, 2016-01-29 18:51:54]

lgtm

https://codereview.chromium.org/1644043003/diff/100001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1644043003/diff/100001/dm/DMSrcSink.cpp#newco...
dm/DMSrcSink.cpp:1254: SkMojo::FlattenedPicturePtr mojoPicture =
SkMojo::FlattenedPicture::New();
Just curious, is this a typedef for something like 
std::unique_ptr<SkMojo::FlattenedPicture> ?

https://codereview.chromium.org/1644043003/diff/100001/dm/DMSrcSink.cpp#newco...
dm/DMSrcSink.cpp:1281: #else // not SK_MOJO
This comment is probably no longer useful.

https://codereview.chromium.org/1644043003/diff/100001/gyp/skmojo.gyp
File gyp/skmojo.gyp (right):

https://codereview.chromium.org/1644043003/diff/100001/gyp/skmojo.gyp#newcode32
gyp/skmojo.gyp:32: 'defines': [ 'SK_MOJO' ],
This code doesn't actually need SK_MOJO defined, does it?  It's just a signal to
people who use it?

[hal.canary, 2016-01-29 18:53:43]

Description was changed from

==========
Mojo WIP

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkMojo: test linking Skia against the Mojo SDK

TODO: build on systems other than Linux.

Add mojo_skd to the DEPS.

Add a DM::Via called `mojo-`.

everything is hidden behind the gyp variable `skia_mojo`.
==========

[reed1, 2016-01-29 19:54:01]

reed@google.com changed reviewers:
+ djsollen@google.com

[commit-bot: I haz the power, 2016-01-30 17:59:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 17:59:01]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-01-30 19:54:38]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-01-30 19:54:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644043003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644043003/100001

[commit-bot: I haz the power, 2016-01-30 19:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 19:55:52]

Try jobs failed on following builders:
  Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-...)

[hal.canary, 2016-02-03 18:53:48]

Description was changed from

==========
SkMojo: test linking Skia against the Mojo SDK

TODO: build on systems other than Linux.

Add mojo_skd to the DEPS.

Add a DM::Via called `mojo-`.

everything is hidden behind the gyp variable `skia_mojo`.
==========

to

==========
SkMojo: test linking Skia against the Mojo SDK

TODO: build on systems other than Linux.

Add mojo_skd to the DEPS.

Add a DM::Via called `mojo-`.

everything is hidden behind the gyp variable `skia_mojo`.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-02-03 18:54:08]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-02-03 18:54:08]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1644043003/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-02-03 18:54:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644043003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644043003/120001

[hal.canary, 2016-02-03 19:16:07]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-02-03 19:16:07]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1644043003/#ps140001
(title: "fix")

[commit-bot: I haz the power, 2016-02-03 19:16:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644043003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644043003/140001

[commit-bot: I haz the power, 2016-02-03 19:53:21]

Description was changed from

==========
SkMojo: test linking Skia against the Mojo SDK

TODO: build on systems other than Linux.

Add mojo_skd to the DEPS.

Add a DM::Via called `mojo-`.

everything is hidden behind the gyp variable `skia_mojo`.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkMojo: test linking Skia against the Mojo SDK

TODO: build on systems other than Linux.

Add mojo_skd to the DEPS.

Add a DM::Via called `mojo-`.

everything is hidden behind the gyp variable `skia_mojo`.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7a76f9c8f4de11e51b3495eec0d76be88a12adfa
==========

[commit-bot: I haz the power, 2016-02-03 19:53:22]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/7a76f9c8f4de11e51b3495eec0d76be88a12adfa