Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1644023003: Fix Timeline reporting crash when reusing timeline events with preserialized json (Closed)

Created:
4 years, 10 months ago by Cutch
Modified:
4 years, 10 months ago
Reviewers:
jsimmons1, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Timeline reporting crash when reusing timeline events with preserialized json BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c4bbf89fe14a234d7e3c958a44915b3c738ac95d

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M runtime/vm/timeline.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Cutch
4 years, 10 months ago (2016-01-29 00:15:22 UTC) #4
Cutch
4 years, 10 months ago (2016-01-29 00:15:39 UTC) #6
rmacnak
lgtm
4 years, 10 months ago (2016-01-29 00:16:56 UTC) #7
Cutch
Committed patchset #2 (id:20001) manually as c4bbf89fe14a234d7e3c958a44915b3c738ac95d (presubmit successful).
4 years, 10 months ago (2016-01-29 00:20:35 UTC) #9
zra
4 years, 10 months ago (2016-01-29 03:02:05 UTC) #10
Message was sent while issue was closed. 
On 2016/01/29 00:20:35, Cutch wrote:
> Committed patchset #2 (id:20001) manually as
> c4bbf89fe14a234d7e3c958a44915b3c738ac95d (presubmit successful).

Thanks!

Powered by Google App Engine
This is Rietveld 408576698