[wasm] Fix misaligned accesses and endianness issues in decoders.

[wasm] Fix misaligned accesses and endianness issues in decoders.

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=

Committed: https://crrev.com/716bc803a3bf5e1c0bae815f865281881a74dbc4
Cr-Commit-Position: refs/heads/master@{#33595}

[ahaas, 2016-01-28 18:58:33]

lgtm

nits

https://codereview.chromium.org/1644023002/diff/1/src/wasm/decoder.h
File src/wasm/decoder.h (right):

https://codereview.chromium.org/1644023002/diff/1/src/wasm/decoder.h#newcode52
src/wasm/decoder.h:52: #else
what if "V8_TARGET_LITTLE_ENDIAN && !UNALIGNED_ACCESS_OK"?

https://codereview.chromium.org/1644023002/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/1644023002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:433: : "string");  // TODO(titzer): validate string
Put the comment into a separate line, so that the there is no line break in the
actual code.

[titzer, 2016-01-28 19:00:43]

On 2016/01/28 18:58:33, ahaas wrote:
> lgtm
> 
> nits
> 
> https://codereview.chromium.org/1644023002/diff/1/src/wasm/decoder.h
> File src/wasm/decoder.h (right):
> 
> https://codereview.chromium.org/1644023002/diff/1/src/wasm/decoder.h#newcode52
> src/wasm/decoder.h:52: #else
> what if "V8_TARGET_LITTLE_ENDIAN && !UNALIGNED_ACCESS_OK"?
> 

It will default to the other case and do a byte-by-byte read.

> https://codereview.chromium.org/1644023002/diff/1/src/wasm/module-decoder.cc
> File src/wasm/module-decoder.cc (right):
> 
>
https://codereview.chromium.org/1644023002/diff/1/src/wasm/module-decoder.cc#...
> src/wasm/module-decoder.cc:433: : "string");  // TODO(titzer): validate string
> Put the comment into a separate line, so that the there is no line break in
the
> actual code.

Done.

[titzer, 2016-01-28 19:00:48]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-01-28 19:00:49]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/1644023002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-01-28 19:00:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1644023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1644023002/20001

[commit-bot: I haz the power, 2016-01-28 19:24:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 19:24:44]

Description was changed from

==========
[wasm] Fix misaligned accesses and endianness issues in decoders.

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=
==========

to

==========
[wasm] Fix misaligned accesses and endianness issues in decoders.

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=

Committed: https://crrev.com/716bc803a3bf5e1c0bae815f865281881a74dbc4
Cr-Commit-Position: refs/heads/master@{#33595}
==========

[commit-bot: I haz the power, 2016-01-28 19:24:45]

Patchset 2 (id:??) landed as
https://crrev.com/716bc803a3bf5e1c0bae815f865281881a74dbc4
Cr-Commit-Position: refs/heads/master@{#33595}

[bradnelson, 2016-01-28 19:25:57]

lgtm