Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1643983002: cc: use Skia's filterBounds() traversal, not computeFastBounds(). (Closed)

Created:
4 years, 10 months ago by Stephen White
Modified:
4 years, 10 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: use Skia's filterBounds() traversal, not computeFastBounds(). filterBounds() is performed in device space, which matches cc's use case (determining the device-space size of a texture to allocate) more closely. Since it also supports the crop rect, this fixes filter regions for accelerated reference filters (crbug.com/240845). BUG=240845 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/65da63c422d51b2d2d8e47d7db53561b12e5b272 Cr-Commit-Position: refs/heads/master@{#372183}

Patch Set 1 #

Patch Set 2 : Fix formatting #

Patch Set 3 : Mark tests to be rebaselined; fix spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M cc/output/gl_renderer.cc View 1 2 1 chunk +7 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Stephen White
enne@: PTAL. Thanks! (Note: this change depends on Skia change https://skia.googlesource.com/skia/+/d8ff5b336e586ad971ebcafa5fb2eb1e7ac95589 rolling into Chrome first.)
4 years, 10 months ago (2016-01-28 16:38:09 UTC) #4
enne (OOO)
lgtm, although I'm curious what changed in the layout tests.
4 years, 10 months ago (2016-01-28 18:24:05 UTC) #5
Stephen White
On 2016/01/28 18:24:05, enne wrote: > lgtm, although I'm curious what changed in the layout ...
4 years, 10 months ago (2016-01-28 18:26:39 UTC) #6
enne (OOO)
Oh, nice!
4 years, 10 months ago (2016-01-28 18:27:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1643983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1643983002/40001
4 years, 10 months ago (2016-01-28 19:36:02 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-01-28 22:26:40 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 22:27:39 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/65da63c422d51b2d2d8e47d7db53561b12e5b272
Cr-Commit-Position: refs/heads/master@{#372183}

Powered by Google App Engine
This is Rietveld 408576698